[webview_flutter] Add an option to bypass SSL checks #7893
+5,188
−6,110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform-android
platform-ios
platform-macos
p: webview_flutter
labels
# Conflicts: # packages/webview_flutter/webview_flutter/CHANGELOG.md # packages/webview_flutter/webview_flutter_android/CHANGELOG.md # packages/webview_flutter/webview_flutter_android/pubspec.yaml # packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md # packages/webview_flutter/webview_flutter_wkwebview/lib/src/foundation/foundation.dart
|
I still have some tests to add, but I would like a first pass to check for bigger issues |
Colman
requested review from
cbracken,
bparrishMines and
ditman
as code owners
ditman
reviewed
Oct 22, 2024
Those changes are needed temporarily because this is a federated plugin. Please see: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changing-federated-plugins |
|
This is blocked by the |
|
from triage: iOS proxy updates are close to landing, at which point this will finally be unblocked. |
|
@bparrishMines Can you take a look at updating this to the new wrapper? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the webview encounters an SSL error, there is no option to be able to bypass the error. This PR implements a callback that gets called with the SSL error and certificate details. A decision can be returned to either ignore the error and proceed, or cancel the request.
flutter/flutter#36925
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.