Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable platform_channels CI #1903

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Re-enable platform_channels CI #1903

merged 2 commits into from
Jun 21, 2023

Conversation

domesticmouse
Copy link
Contributor

@domesticmouse domesticmouse commented Jun 21, 2023 •
edited
Loading

Pre-launch Checklist

  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I read the Contributors Guide.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

@domesticmouse domesticmouse requested review from stuartmorgan and parlough and removed request for stuartmorgan June 21, 2023 12:55
stuartmorgan
stuartmorgan approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry, I didn't realize there was another part to updating the sample.

@domesticmouse
Copy link
Contributor Author

LGTM. Sorry, I didn't realize there was another part to updating the sample.

All good, thanks for the LGTM =)

parlough
parlough approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@johnpryan johnpryan merged commit 679c6c1 into main Jun 21, 2023
@parlough parlough deleted the re-enable-platform_channels-CI branch June 21, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parlough parlough parlough approved these changes

@stuartmorgan stuartmorgan stuartmorgan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@domesticmouse @stuartmorgan @parlough @johnpryan