Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable platform_channels CI #1903

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Re-enable platform_channels CI #1903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32b9e80
Re-enable `platform_channels` CI
domesticmouse Jun 21, 2023
b500468
Don't use `BuildContext`s across async gaps.
domesticmouse Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions platform_channels/lib/src/method_channel_demo.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ class _MethodChannelDemoState extends State<MethodChannelDemo> {
final value = await Counter.increment(counterValue: count);
setState(() => count = value);
} catch (error) {
if (!mounted) return;
showErrorMessage(
context,
(error as PlatformException).message!,
Expand All @@ -64,6 +65,7 @@ class _MethodChannelDemoState extends State<MethodChannelDemo> {
final value = await Counter.decrement(counterValue: count);
setState(() => count = value);
} catch (error) {
if (!mounted) return;
showErrorMessage(
context,
(error as PlatformException).message!,
Expand Down
3 changes: 1 addition & 2 deletions tool/flutter_ci_script_beta.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ declare -ar PROJECT_NAMES=(
# "navigation_and_routing"
"next_gen_ui_demo"
"place_tracker"
# TODO: https://github.com/flutter/samples/issues/1765
# "platform_channels"
"platform_channels"
"platform_design"
"platform_view_swift"
"provider_counter"
Expand Down
3 changes: 1 addition & 2 deletions tool/flutter_ci_script_master.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,7 @@ declare -ar PROJECT_NAMES=(
# TODO: Dependency 'gap-3.0.0' fails to compile
# "next_gen_ui_demo"
"place_tracker"
# TODO: https://github.com/flutter/samples/issues/1765
# "platform_channels"
"platform_channels"
"platform_design"
"platform_view_swift"
"provider_counter"
Expand Down
3 changes: 1 addition & 2 deletions tool/flutter_ci_script_stable.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,7 @@ declare -ar PROJECT_NAMES=(
"navigation_and_routing"
"next_gen_ui_demo"
"place_tracker"
# TODO: https://github.com/flutter/samples/issues/1765
# "platform_channels"
"platform_channels"
"platform_design"
"platform_view_swift"
"provider_counter"
Expand Down