Skip to content

Conversation

Sovietaced
Copy link
Member

@Sovietaced Sovietaced commented Sep 9, 2025

Why are the changes needed?

This pull request removes some code that was not used which simplifies the codebase. It also removes extraneous environment variables that are injected into Flyte task containers, which has been confusing for me.

What changes were proposed in this pull request?

Removes code and removes legacy environment variables.

How was this patch tested?

Unit tests and in our production environment.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary by Bito

This pull request enhances code clarity by removing unused node selector functions and legacy environment variables from Flyte task containers. The cleanup simplifies the codebase and reduces confusion, with updated unit tests ensuring stability and correctness.

@flyte-bot
Copy link
Collaborator

Bito Automatic Review Skipped - Draft PR

Bito didn't auto-review because this pull request is in draft status.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change draft PR review settings here, or contact your Bito workspace admin at [email protected].

Copy link

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.56%. Comparing base (890d564) to head (cd577cb).
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6614      +/-   ##
==========================================
- Coverage   58.59%   58.56%   -0.03%     
==========================================
  Files         929      929              
  Lines       70851    70876      +25     
==========================================
- Hits        41513    41512       -1     
- Misses      26192    26211      +19     
- Partials     3146     3153       +7     
Flag Coverage Δ
unittests-datacatalog 59.03% <ø> (ø)
unittests-flyteadmin 56.13% <ø> (ø)
unittests-flytecopilot 40.87% <ø> (+1.31%) ⬆️
unittests-flytectl 64.64% <ø> (ø)
unittests-flyteidl 76.12% <ø> (ø)
unittests-flyteplugins 61.01% <ø> (-0.10%) ⬇️
unittests-flytepropeller 55.06% <ø> (ø)
unittests-flytestdlib 63.05% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@flyte-bot
Copy link
Collaborator

Bito Automatic Review Skipped - Draft PR

Bito didn't auto-review because this pull request is in draft status.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change draft PR review settings here, or contact your Bito workspace admin at [email protected].

@Sovietaced Sovietaced added the housekeeping Issues that help maintain flyte and keep it tech-debt free label Sep 13, 2025
Value: taskID.GetVersion(),
},
// Historic Task Definition Level env variables.
// Remove these once SDK is migrated to use the new ones.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I validated that the SDK no longer uses these.

@Sovietaced Sovietaced marked this pull request as ready for review September 13, 2025 17:40
@Sovietaced Sovietaced changed the title Remove unused node selector functions in pod_helper.go Remove unused node selector functions & legacy environment variables Sep 13, 2025
@Sovietaced Sovietaced added the removed For features being removed label Sep 26, 2025
@Sovietaced Sovietaced merged commit 293a0df into flyteorg:master Sep 29, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free removed For features being removed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants