-
Notifications
You must be signed in to change notification settings - Fork 748
Remove unused node selector functions & legacy environment variables #6614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jason Parraga <[email protected]>
Bito Automatic Review Skipped - Draft PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6614 +/- ##
==========================================
- Coverage 58.59% 58.56% -0.03%
==========================================
Files 929 929
Lines 70851 70876 +25
==========================================
- Hits 41513 41512 -1
- Misses 26192 26211 +19
- Partials 3146 3153 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bito Automatic Review Skipped - Draft PR |
6e345f1
to
ad8ca5a
Compare
Value: taskID.GetVersion(), | ||
}, | ||
// Historic Task Definition Level env variables. | ||
// Remove these once SDK is migrated to use the new ones. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I validated that the SDK no longer uses these.
Signed-off-by: Jason Parraga <[email protected]>
ad8ca5a
to
cd577cb
Compare
Why are the changes needed?
This pull request removes some code that was not used which simplifies the codebase. It also removes extraneous environment variables that are injected into Flyte task containers, which has been confusing for me.
What changes were proposed in this pull request?
Removes code and removes legacy environment variables.
How was this patch tested?
Unit tests and in our production environment.
Check all the applicable boxes
Summary by Bito
This pull request enhances code clarity by removing unused node selector functions and legacy environment variables from Flyte task containers. The cleanup simplifies the codebase and reduces confusion, with updated unit tests ensuring stability and correctness.