This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Additional catalog client functionality for cache eviction #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #301 +/- ##
==========================================
+ Coverage 62.35% 63.53% +1.18%
==========================================
Files 147 145 -2
Lines 11809 9334 -2475
==========================================
- Hits 7363 5930 -1433
+ Misses 3882 2859 -1023
+ Partials 564 545 -19
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
added 2 commits
January 4, 2023 16:04
Extended reservation retrieval to allow querying via artifact tag in catalog client interface Signed-off-by: Nick Müller <[email protected]>
Added method to delete catalog artifact by ID Signed-off-by: Nick Müller <[email protected]>
MorpheusXAUT
force-pushed
the
cache-eviction-past-executions
branch
from
3ce2c13
to
bda210e
Compare
|
Rebased onto current |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added extra methods for accessing and removing artifact data to catalog client.
Type
Are all requirements met?
Complete description
The new
ByArtifactTagmethods were added to allow for easier access to reservations from flyteadmin (which retrieves the artifact tag from its stored metadata without having to access the stored artifact to generate acatalog.Key).Additional functionality for deleting artifacts has been added as well.
Tracking Issue
flyteorg/flyte#2867
Follow-up issue
NA