Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move nim from flyte agents to flytekit plugins #1716

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

samhita-alla
Copy link
Contributor

No description provided.

Copy link
Member

@Future-Outlier Future-Outlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Future-Outlier Future-Outlier enabled auto-merge (squash) August 2, 2024 05:04
@eapolinario
Copy link
Collaborator

Why aren't the CI checks running?

@eapolinario eapolinario closed this Aug 2, 2024
auto-merge was automatically disabled August 2, 2024 13:55

Pull request was closed

@eapolinario eapolinario reopened this Aug 2, 2024
@eapolinario
Copy link
Collaborator

eapolinario commented Aug 2, 2024

Why aren't the CI checks running?

that's why. We skip the checks.yml gh workflow if changes are made only to files under docs, but Register example to sandbox is a required CI check that lives there.

I'm going to force-merge this PR once the monodocs checks pass.

@eapolinario eapolinario merged commit 83fc575 into master Aug 2, 2024
4 of 5 checks passed
@eapolinario eapolinario deleted the samhita-alla-patch-1 branch August 2, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants