Enhanced MSSQLShell in NTLMRelayX leveraging TcpShell (as in SMB an… #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielg5
changed the title
|
Can you also take a look at it @sploutchy please, as this will change how to interact with the shell? |
|
Hi @gabrielg5, Cheers |
|
Yes, you are right! That behavior is the same for all 3 interactive shells (SMB, MSSQL, LDAP) I've been checking how all that is implemented and think I have a solution to try. However I think will be creating a new PR for that as it will be impacting more than just the sql shell |
gabrielg5
force-pushed
the
interactive_sqlshell_fixes
branch
from
4d7a405
to
6a3ecf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1612
Followed the same approach as it was followed in SMB / LDAP interactive shells.
Leveraging TcpShell to avoid mixing messages with the relay