Remove Linter Message Unknown Header #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franziska-wegner
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
=======================================
Coverage 94.57% 94.57%
=======================================
Files 55 55
Lines 5049 5049
=======================================
Hits 4775 4775
Misses 274 274 ☔ View full report in Codecov by Sentry. |
…age: QDebug file not found
franziska-wegner
force-pushed
the
franziska-wegner/2024/january/CI/remove-unknown-include-from-linter-messages
branch
from
ce0f452
to
c429a7c
Compare
franziska-wegner
commented
Jan 7, 2024
| @@ -122,6 +132,8 @@ jobs: | |||
| files-changed-only: false | |||
| lines-changed-only: false | |||
| no-lgtm: false | |||
| repo-root: ${{ github.workspace }} | |||
| extra-args: "-I./include -I./tests -I${{ steps.strings.outputs.google-test-dir }}/googletest/include -I${{ steps.strings.outputs.github.workspace }}/googletest -I${{ steps.strings.outputs.google-test-dir }}/googlemock/include -I${{ steps.strings.outputs.google-test-dir }}/googlemock -isystem ${{ steps.strings.outputs.qt-include-dir }}/QtCore -isystem ${{ steps.strings.outputs.qt-include-dir }} -isystem ${{ steps.strings.outputs.qt-main-dir }}/mkspecs/linux-g++ -isystem ${{ steps.strings.outputs.qt-include-dir }}/QtQuick -isystem ${{ steps.strings.outputs.qt-include-dir }}/QtGui -isystem ${{ steps.strings.outputs.qt-include-dir }}/QtQml -isystem ${{ steps.strings.outputs.qt-include-dir }}/QtNetwork -isystem ${{ steps.strings.outputs.qt-include-dir }}/QtQmlModels -isystem ${{ steps.strings.outputs.qt-include-dir }}/QtOpenGL -isystem ${{ steps.strings.outputs.qt-include-dir }}/QtWidgets -I${{ steps.strings.outputs.qt-lib-dir }}/QtCore.framework/Versions/A/Headers/QDebug -I${{ steps.strings.outputs.qt-lib-dir }}/QtCore.framework/Versions/A/Headers/QFile" | |||
There was a problem hiding this comment.
The linter has still issues to find the QDebug and QFile. Further, investigation is necessary.
franziska-wegner
deleted the
franziska-wegner/2024/january/CI/remove-unknown-include-from-linter-messages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add project build to the linter process to make header known for the linter.
The linter has still issues to find the
QDebugandQFile. Further, investigation is necessary.