Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Linter Message Unknown Header #104

Merged
merged 22 commits into from
Jan 7, 2024
Merged

Remove Linter Message Unknown Header #104

Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
6b42ae8
Add build to the linter process to make header known for the process
franziska-wegner Jan 7, 2024
dc7d971
Add repo root
franziska-wegner Jan 7, 2024
c7e0d51
Use main instead of a fixed version of the linter repo
franziska-wegner Jan 7, 2024
668161f
Add include directories for the linter
franziska-wegner Jan 7, 2024
989c779
Temp echo for qt
franziska-wegner Jan 7, 2024
0b6f644
Update Qt path
franziska-wegner Jan 7, 2024
1dc0c1a
Add the Qt version to the path
franziska-wegner Jan 7, 2024
18b9ff8
Add architecture to the directory path
franziska-wegner Jan 7, 2024
8343f95
Some refactoring for easy changes
franziska-wegner Jan 7, 2024
14176b9
Add lib to include as the QFile and QDebug are in the lib folder
franziska-wegner Jan 7, 2024
32765f8
Valid?
franziska-wegner Jan 7, 2024
0b1a44d
Add prefix steps.strings.outputs
franziska-wegner Jan 7, 2024
c45d50f
Add test to cover error message: Helper/TestHelper.hpp file not found
franziska-wegner Jan 7, 2024
7ee457e
Add specifig QDebug folder and check whether this resolves error mess…
franziska-wegner Jan 7, 2024
89f6f32
Typo in the folder name
franziska-wegner Jan 7, 2024
6d150f1
Build is not necessary for this job
franziska-wegner Jan 7, 2024
c429a7c
Update include
franziska-wegner Jan 7, 2024
a68496c
Add gmock and gtest includes
franziska-wegner Jan 7, 2024
124b1cd
Check on these QT includes to resolve the QFile and QDebug issue
franziska-wegner Jan 7, 2024
fe6f60f
Add Qt flags and googletest includes
franziska-wegner Jan 7, 2024
116cc0f
Check this again and the output
franziska-wegner Jan 7, 2024
6bbf178
Explicit file include
franziska-wegner Jan 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion .github/workflows/cpp-linter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ concurrency:

env:
QT_VERSION: "6.2.0"
QT_ARCH: "gcc_64"

permissions:
contents: read
Expand Down Expand Up @@ -57,6 +58,10 @@ jobs:
shell: bash
run: |
echo "build-output-dir=${{ github.workspace }}/build" >> "$GITHUB_OUTPUT"
echo "qt-main-dir=${{ github.workspace }}/Qt/Qt/${{ env.QT_VERSION }}/${{ env.QT_ARCH }}" >> "$GITHUB_OUTPUT"
echo "qt-include-dir=${{ steps.strings.outputs.qt-main-dir }}/include" >> "$GITHUB_OUTPUT"
echo "qt-lib-dir=${{ steps.strings.outputs.qt-main-dir }}/lib" >> "$GITHUB_OUTPUT"
echo "google-test-dir=${{ github.workspace }}/external/GoogleTestFramework" >> "$GITHUB_OUTPUT"
- name: Configure CMake
env:
Expand Down Expand Up @@ -110,8 +115,13 @@ jobs:
-DOPENMP_LIBRARIES="/opt/homebrew/opt/llvm/lib"
-S ${{ github.workspace }}
- name: Build (Unix)
# Build your program with the given configuration. Note that --config is needed because the default Windows generator is a multi-config generator (Visual Studio generator).
if: ${{ !startsWith(matrix.os,'windows-') }}
run: sudo cmake --build ${{ steps.strings.outputs.build-output-dir }} --config ${{ matrix.build_type }}

- name: C/C++ Linter
uses: cpp-linter/cpp-linter-action@v2.7.5
uses: cpp-linter/cpp-linter-action@main
id: linter
continue-on-error: true
env:
Expand All @@ -122,6 +132,8 @@ jobs:
files-changed-only: false
lines-changed-only: false
no-lgtm: false
repo-root: ${{ github.workspace }}
extra-args: "-I./include -I./tests -I${{ steps.strings.outputs.google-test-dir }}/googletest/include -I${{ steps.strings.outputs.github.workspace }}/googletest -I${{ steps.strings.outputs.google-test-dir }}/googlemock/include -I${{ steps.strings.outputs.google-test-dir }}/googlemock -isystem ${{ steps.strings.outputs.qt-include-dir }}/QtCore -isystem ${{ steps.strings.outputs.qt-include-dir }} -isystem ${{ steps.strings.outputs.qt-main-dir }}/mkspecs/linux-g++ -isystem ${{ steps.strings.outputs.qt-include-dir }}/QtQuick -isystem ${{ steps.strings.outputs.qt-include-dir }}/QtGui -isystem ${{ steps.strings.outputs.qt-include-dir }}/QtQml -isystem ${{ steps.strings.outputs.qt-include-dir }}/QtNetwork -isystem ${{ steps.strings.outputs.qt-include-dir }}/QtQmlModels -isystem ${{ steps.strings.outputs.qt-include-dir }}/QtOpenGL -isystem ${{ steps.strings.outputs.qt-include-dir }}/QtWidgets -I${{ steps.strings.outputs.qt-lib-dir }}/QtCore.framework/Versions/A/Headers/QDebug -I${{ steps.strings.outputs.qt-lib-dir }}/QtCore.framework/Versions/A/Headers/QFile"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter has still issues to find the QDebug and QFile. Further, investigation is necessary.

# The following value will only update a single comment
# in a pull request's thread. Set it to false to disable the comment.
# Set it to true to post a new comment (and delete the old comment).
Expand Down
Loading