Skip to content

thirdparty: update bundled SIMDE to fix link error on musl/non-glibc#684

Merged
K-os merged 1 commit intofraunhoferhhi:masterfrom
kjg0724:fix/update-bundled-simde
Apr 13, 2026
Merged

thirdparty: update bundled SIMDE to fix link error on musl/non-glibc#684
K-os merged 1 commit intofraunhoferhhi:masterfrom
kjg0724:fix/update-bundled-simde

Conversation

@kjg0724
Copy link
Copy Markdown
Contributor

@kjg0724 kjg0724 commented Apr 2, 2026

Reopens #682.

Accidentally closed the previous PR — apologies for the confusion.

Updates thirdparty/simde to simd-everywhere/simde@cb5b957, which includes:

Both fixes address link errors on musl/non-glibc systems. CI was green on #682.

@kjg0724
Copy link
Copy Markdown
Contributor Author

kjg0724 commented Apr 2, 2026

Hi @adamjw24 — sorry again for the confusion with #682.

This PR (#684) is identical in content. The only change from #682 is that it's now created from a proper fork.

The core change: SIMDE updated to cb5b957, adding compile-time guards for roundeven and exp10 which caused link errors on musl-based (non-glibc) systems. No logic changes to vvenc itself — purely a bundled dependency update.

Would appreciate a review when you get a chance. Happy to address any feedback.

@adamjw24 adamjw24 requested a review from K-os April 10, 2026 16:35
Copy link
Copy Markdown
Collaborator

@K-os K-os left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, in principle this looks good. I just have one small change request:
We pull the simd-everywhere dependency directly from this repository: https://github.com/simd-everywhere/simde-no-tests.git
So, could you please update the commit message to point to the corresponding commit in that repository to prevent confusion? I think it should be simd-everywhere/simde-no-tests@8574c41

@kjg0724 kjg0724 force-pushed the fix/update-bundled-simde branch from f12c155 to 60f6817 Compare April 13, 2026 08:15
@kjg0724
Copy link
Copy Markdown
Contributor Author

kjg0724 commented Apr 13, 2026

Updated the commit message to reference simd-everywhere/simde-no-tests@8574c41 as requested.

@K-os K-os self-requested a review April 13, 2026 11:25
Copy link
Copy Markdown
Collaborator

@K-os K-os left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks. Looks good now.

@K-os K-os merged commit a8f7645 into fraunhoferhhi:master Apr 13, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants