thirdparty: update bundled SIMDE to fix link error on musl/non-glibc#684
Conversation
|
Hi @adamjw24 — sorry again for the confusion with #682. This PR (#684) is identical in content. The only change from #682 is that it's now created from a proper fork. The core change: SIMDE updated to cb5b957, adding compile-time guards for Would appreciate a review when you get a chance. Happy to address any feedback. |
K-os
left a comment
There was a problem hiding this comment.
Thanks, in principle this looks good. I just have one small change request:
We pull the simd-everywhere dependency directly from this repository: https://github.com/simd-everywhere/simde-no-tests.git
So, could you please update the commit message to point to the corresponding commit in that repository to prevent confusion? I think it should be simd-everywhere/simde-no-tests@8574c41
f12c155 to
60f6817
Compare
|
Updated the commit message to reference simd-everywhere/simde-no-tests@8574c41 as requested. |
K-os
left a comment
There was a problem hiding this comment.
Ok, thanks. Looks good now.
Reopens #682.
Accidentally closed the previous PR — apologies for the confusion.
Updates thirdparty/simde to simd-everywhere/simde@cb5b957, which includes:
Both fixes address link errors on musl/non-glibc systems. CI was green on #682.