fix(ai): explicit allow-list for ask-loop approval (refactor-safety)#1265
Merged
Conversation
The permission ask-loop treated any non-"deny" answer as approval
(`response.get("answer") == "deny"` → deny, else proceed). Both backends
currently normalize to exactly "allow"/"deny", so this is behavior-neutral
today — but it's deny-list shaped: a new backend or a refactored answer
vocabulary could silently approve through a "not deny" gap.
Flip the three prompt sites (shell/target/path) to an explicit allow-list via
`_is_approved()`: only a normalized "allow" answer proceeds; None, "deny", or
any unexpected token denies (fail closed). Surfaced during the AI-task review
(round 2 backlog, item 2).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round-2 backlog item #2 from the AI-task review. The permission ask-loop in
actions.pyapproved on any non-denyanswer (deny-list shape). Both backends normalize to exactlyallow/denytoday, so this is behavior-neutral now — but a new backend or a refactored token could slip through the gap.Flips the three prompt sites (shell/target/path) to an explicit allow-list via a small
_is_approved()helper: only a normalizedallowproceeds;None,deny, or any unexpected token denies (fail closed).Tests:
test_ai_actions.py75→79 (+4: allow proceeds, deny denies, unexpected token denies, None denies). No regressions.Folds into the aggregate #1241.