Updating GardenSnake validParams() to a static member function among other things#3
Open
Ramzy1990 wants to merge 5 commits intofriedmud:masterfrom
Open
Updating GardenSnake validParams() to a static member function among other things#3Ramzy1990 wants to merge 5 commits intofriedmud:masterfrom
Ramzy1990 wants to merge 5 commits intofriedmud:masterfrom
Conversation
added 5 commits
June 20, 2023 02:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Derek,
I have updated Gardensnake to be compatible with the new moose. Or at least I updated those parts that can hinder the compilation of Gardensnake under the new moose.
Running the input files kept showing errors for variables that are not used, so I just commented those out (under [fission_change] postprocessor, and under [xs_mat] materials in problem 4).
I intend to use this open source neutronics module for some work. Can you give some general notes/hints on how to generalize Gardensnake to 2D/3D please?
Thank you,
Ramzy