Bump react, react-dom versions to 19.1.0, bump mui to 5.16.12 #3008
Conversation
WalkthroughThe package.json file was updated to upgrade React, React DOM, and their TypeScript type definitions from version 18.3.x to 19.1.0. Additionally, Material-UI packages @mui/material, @mui/material-nextjs, and @mui/system were upgraded from 5.16.6 to 5.16.12. No other dependencies or scripts were changed. Changes
Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (26)
📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
[zzz-frontend] [Wed Jul 9 15:01:54 UTC 2025] - Deployed a5a57a6 to https://genshin-optimizer-prs.github.io/pr/3008/zzz-frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Wed Jul 9 15:02:09 UTC 2025] - Deployed a5a57a6 to https://genshin-optimizer-prs.github.io/pr/3008/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Wed Jul 9 15:04:14 UTC 2025] - Deployed a5a57a6 to https://genshin-optimizer-prs.github.io/pr/3008/frontend (Takes 3-5 minutes after this completes to be available) [zzz-frontend] [Sun Jul 13 19:55:47 UTC 2025] - Deployed c1638bd to https://genshin-optimizer-prs.github.io/pr/3008/zzz-frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Sun Jul 13 19:56:20 UTC 2025] - Deployed c1638bd to https://genshin-optimizer-prs.github.io/pr/3008/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Sun Jul 13 19:57:30 UTC 2025] - Deployed c1638bd to https://genshin-optimizer-prs.github.io/pr/3008/frontend (Takes 3-5 minutes after this completes to be available) |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
package.json (1)
47-48: Minor: keep@types/react(-dom)in devDeps onlyType packages don’t belong in
"dependencies"for production bundles. They should sit in"devDependencies"alongside TypeScript tooling, saving a few kilobytes from the final lockfile.If there’s no runtime import, shift them:
"devDependencies": { - "@types/react": "19.1.0", - "@types/react-dom": "19.1.0", + "@types/react": "19.1.0", + "@types/react-dom": "19.1.0",(Yes, tiny, but every primogem counts.)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (11)
.yarn/cache/@types-react-dom-npm-18.3.0-111444d3eb-a0cd9b1b81.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/@types-react-dom-npm-19.1.0-a0127aeb61-9bd88e628a.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/@types-react-npm-18.3.1-5744cb1fe5-9224ef319a.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/@types-react-npm-19.1.0-fba5aaa1ad-7dd7e02189.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/react-dom-npm-18.3.1-a805663f38-298954ecd8.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/react-dom-npm-19.1.0-773f826e46-1d154b6543.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/react-npm-18.3.1-af38f3c1ae-a27bcfa8ff.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/react-npm-19.1.0-9804a7da5b-c0905f8cfb.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/scheduler-npm-0.23.2-6d1dd9c2b7-3e82d1f419.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/scheduler-npm-0.26.0-980301a213-c63a9f1c0e.zipis excluded by!**/.yarn/**,!**/*.zipyarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (1)
package.json(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
- GitHub Check: call-build / build
- GitHub Check: lint
- GitHub Check: typecheck
- GitHub Check: format
- GitHub Check: call-build / build
- GitHub Check: gen-file
- GitHub Check: test
- GitHub Check: call-build / build
- GitHub Check: call-build / build
- GitHub Check: call-build / build
| "react": "19.1.0", | ||
| "react-dom": "19.1.0", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Ugh, 3 AM brain talking here: Next.js 14.2.5 and a pile of other libs in this repo are still peer-pinned to React 18. Dropping in "react": "19.1.0" and matching @types/* looks nice in the gacha banner, but expect red screens instead of sparkle animations:
• next@14 officially peers on ^18.2 – no React 19 support yet.
• @testing-library/[email protected], MUI 5, [email protected], etc. haven’t published 19-ready versions.
=> Runtime or type‐level mismatches, install warnings, maybe outright build failure.
Before merging, either:
- Upgrade framework/libs that already state React 19 peer ranges (Next 15 beta, MUI 6 alpha, etc.), or
- Hold this bump until ecosystem catches up.
Run a quick sanity scan:
Expect non-zero hits for 18.x ranges – those will need attention.
Also applies to: 47-48
🏁 Script executed:
#!/bin/bash
# Show packages that explicitly depend on react@^18
jq '.dependencies + .devDependencies' -r package.json | \
grep -E '"(@types/)?react(-dom)?":' -n
echo "--- Peer deps expecting react@18 ---"
fd package.json | xargs jq -r '.peerDependencies? // {}' | \
grep -E '"react":' | sort | uniq -cLength of output: 394
I’m running on fumes here, but let’s double-check which versions of Next.js, MUI, Testing Library and React Router we’ve pinned:
🏁 Script executed:
#!/bin/bash
# 📦 Check core framework & library versions in package.json
jq '.dependencies + .devDependencies' -r package.json | \
grep -E '"next":' -n
jq '.dependencies + .devDependencies' -r package.json | \
grep -E '"@testing-library/react":' -n
jq '.dependencies + .devDependencies' -r package.json | \
grep -E '"react-router-dom":' -n
jq '.dependencies + .devDependencies' -r package.json | \
grep -E '"@mui/material":' -nLength of output: 485
Ugh, can’t tell if I’m hallucinating or just delirious—let’s peek at the actual peer-ranges on npm before we pull the lever:
🏁 Script executed:
#!/bin/bash
echo "🔍 [email protected] peerDependencies:"
npm view [email protected] peerDependencies --json
echo "🔍 @testing-library/[email protected] peerDependencies:"
npm view @testing-library/[email protected] peerDependencies --json
echo "🔍 [email protected] peerDependencies:"
npm view [email protected] peerDependencies --json
echo "🔍 @mui/[email protected] peerDependencies:"
npm view @mui/[email protected] peerDependencies --jsonLength of output: 1167
Ugh, running on empty here—Next.js and MUI aren’t ready for React 19, so you’ll hit red screens:
• package.json “next”: “14.2.5” peers on react@^18.2.0 (no 19 support)
• package.json “@mui/material”: “^5.16.6” peers on react@^17.0.0 || ^18.0.0
• package.json “react”: “19.1.0” & “react-dom”: “19.1.0” (current bump)
• @testing-library/[email protected] peers on ^18.0.0 || ^19.0.0 (✅)
• [email protected] peers on >=16.8 (✅)
Before merging, choose one:
- Upgrade Next.js to v15 beta & MUI to v6 alpha (both React 19-ready)
- Hold the React 19 bump until the rest of the ecosystem catches up
🤖 Prompt for AI Agents
In package.json around lines 113 to 114, the React version is set to 19.1.0,
which is incompatible with the current Next.js v14.2.5 and MUI v5.16.6 versions
that expect React 18 or earlier. To fix this, either downgrade React and
React-DOM to version 18.x to match the peer dependencies or upgrade Next.js to
v15 beta and MUI to v6 alpha that support React 19. Choose one approach and
update the package.json dependencies accordingly before merging.
priolette
changed the title
Describe your changes
Bump react and react-dom versions to 19.1.0, bump mui to 5.16.12
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-cilocally to validate format and lint.Summary by CodeRabbit