Skip to content

Bump react, react-dom versions to 19.1.0, bump mui to 5.16.12 #3008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bump react, react-dom versions to 19.1.0, bump mui to 5.16.12 #3008

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87e7904
Bump react and react-dom versions to 19.1.0
priolette Jul 9, 2025
c7a1b6e
update mui to 5.16.12
priolette Jul 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed .yarn/cache/@types-react-dom-npm-18.3.0-111444d3eb-a0cd9b1b81.zip
View file
Open in desktop
Binary file not shown.
Binary file added .yarn/cache/@types-react-dom-npm-19.1.0-a0127aeb61-9bd88e628a.zip
View file
Open in desktop
Binary file not shown.
Binary file removed .yarn/cache/@types-react-npm-18.3.1-5744cb1fe5-9224ef319a.zip
View file
Open in desktop
Binary file not shown.
Binary file added .yarn/cache/@types-react-npm-19.1.0-fba5aaa1ad-7dd7e02189.zip
View file
Open in desktop
Binary file not shown.
Binary file removed .yarn/cache/react-dom-npm-18.3.1-a805663f38-298954ecd8.zip
View file
Open in desktop
Binary file not shown.
Binary file added .yarn/cache/react-dom-npm-19.1.0-773f826e46-1d154b6543.zip
View file
Open in desktop
Binary file not shown.
Binary file removed .yarn/cache/react-npm-18.3.1-af38f3c1ae-a27bcfa8ff.zip
View file
Open in desktop
Binary file not shown.
Binary file added .yarn/cache/react-npm-19.1.0-9804a7da5b-c0905f8cfb.zip
View file
Open in desktop
Binary file not shown.
Binary file removed .yarn/cache/scheduler-npm-0.23.2-6d1dd9c2b7-3e82d1f419.zip
View file
Open in desktop
Binary file not shown.
Binary file added .yarn/cache/scheduler-npm-0.26.0-980301a213-c63a9f1c0e.zip
View file
Open in desktop
Binary file not shown.
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@
"@types/jest": "29.5.14",
"@types/json-bigint": "^1.0.4",
"@types/node": "^18.16.9",
"@types/react": "18.3.1",
"@types/react-dom": "18.3.0",
"@types/react": "19.1.0",
"@types/react-dom": "19.1.0",
"@types/xxhashjs": "^0.2.4",
"@typescript-eslint/eslint-plugin": "7.16.0",
"@typescript-eslint/parser": "7.16.0",
Expand Down Expand Up @@ -110,8 +110,8 @@
"i18next-fs-backend": "^2.3.1",
"i18next-http-backend": "^2.1.1",
"next": "14.2.5",
"react": "18.3.1",
"react-dom": "18.3.1",
"react": "19.1.0",
"react-dom": "19.1.0",
Comment on lines +113 to +114
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

⚠️ React 19 bump may brick the party

Ugh, 3 AM brain talking here: Next.js 14.2.5 and a pile of other libs in this repo are still peer-pinned to React 18. Dropping in "react": "19.1.0" and matching @types/* looks nice in the gacha banner, but expect red screens instead of sparkle animations:

• next@14 officially peers on ^18.2 – no React 19 support yet.
• @testing-library/[email protected], MUI 5, [email protected], etc. haven’t published 19-ready versions.
=> Runtime or type‐level mismatches, install warnings, maybe outright build failure.

Before merging, either:

  1. Upgrade framework/libs that already state React 19 peer ranges (Next 15 beta, MUI 6 alpha, etc.), or
  2. Hold this bump until ecosystem catches up.

Run a quick sanity scan:

Expect non-zero hits for 18.x ranges – those will need attention.

Also applies to: 47-48

🏁 Script executed:

#!/bin/bash
# Show packages that explicitly depend on react@^18
jq '.dependencies + .devDependencies' -r package.json | \
grep -E '"(@types/)?react(-dom)?":' -n
echo "--- Peer deps expecting react@18 ---"
fd package.json | xargs jq -r '.peerDependencies? // {}' | \
grep -E '"react":' | sort | uniq -c

Length of output: 394

I’m running on fumes here, but let’s double-check which versions of Next.js, MUI, Testing Library and React Router we’ve pinned:

🏁 Script executed:

#!/bin/bash
# 📦 Check core framework & library versions in package.json
jq '.dependencies + .devDependencies' -r package.json | \
  grep -E '"next":' -n
jq '.dependencies + .devDependencies' -r package.json | \
  grep -E '"@testing-library/react":' -n
jq '.dependencies + .devDependencies' -r package.json | \
  grep -E '"react-router-dom":' -n
jq '.dependencies + .devDependencies' -r package.json | \
  grep -E '"@mui/material":' -n

Length of output: 485

Ugh, can’t tell if I’m hallucinating or just delirious—let’s peek at the actual peer-ranges on npm before we pull the lever:

🏁 Script executed:

#!/bin/bash
echo "🔍 [email protected] peerDependencies:"
npm view [email protected] peerDependencies --json

echo "🔍 @testing-library/[email protected] peerDependencies:"
npm view @testing-library/[email protected] peerDependencies --json

echo "🔍 [email protected] peerDependencies:"
npm view [email protected] peerDependencies --json

echo "🔍 @mui/[email protected] peerDependencies:"
npm view @mui/[email protected] peerDependencies --json

Length of output: 1167

⚠️ React 19 bump incompatible with Next.js v14 & MUI v5

Ugh, running on empty here—Next.js and MUI aren’t ready for React 19, so you’ll hit red screens:

• package.json “next”: “14.2.5” peers on react@^18.2.0 (no 19 support)
• package.json “@mui/material”: “^5.16.6” peers on react@^17.0.0 || ^18.0.0
• package.json “react”: “19.1.0” & “react-dom”: “19.1.0” (current bump)
• @testing-library/[email protected] peers on ^18.0.0 || ^19.0.0 (✅)
• [email protected] peers on >=16.8 (✅)

Before merging, choose one:

  1. Upgrade Next.js to v15 beta & MUI to v6 alpha (both React 19-ready)
  2. Hold the React 19 bump until the rest of the ecosystem catches up
🤖 Prompt for AI Agents 
In package.json around lines 113 to 114, the React version is set to 19.1.0,
which is incompatible with the current Next.js v14.2.5 and MUI v5.16.6 versions
that expect React 18 or earlier. To fix this, either downgrade React and
React-DOM to version 18.x to match the peer dependencies or upgrade Next.js to
v15 beta and MUI to v6 alpha that support React 19. Choose one approach and
update the package.json dependencies accordingly before merging.

"react-ga4": "^2.1.0",
"react-i18next": "^13.3.1",
"react-markdown": "^8.0.5",
Expand Down
64 changes: 29 additions & 35 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7545,12 +7545,12 @@ __metadata:
languageName: node
linkType: hard

"@types/react-dom@npm:18.3.0":
version: 18.3.0
resolution: "@types/react-dom@npm:18.3.0"
dependencies:
"@types/react": "*"
checksum: a0cd9b1b815a6abd2a367a9eabdd8df8dd8f13f95897b2f9e1359ea3ac6619f957c1432ece004af7d95e2a7caddbba19faa045f831f32d6263483fc5404a7596
"@types/react-dom@npm:19.1.0":
version: 19.1.0
resolution: "@types/react-dom@npm:19.1.0"
peerDependencies:
"@types/react": ^19.0.0
checksum: 9bd88e628a0e90c81472f1513dd3e3593af3304754f264357ccee73c5a74af1276b078725a5913f5188561331f72f877a6417a3fb915813b596af66f74dbb4c6
languageName: node
linkType: hard

Expand All @@ -7574,13 +7574,12 @@ __metadata:
languageName: node
linkType: hard

"@types/react@npm:18.3.1":
version: 18.3.1
resolution: "@types/react@npm:18.3.1"
"@types/react@npm:19.1.0":
version: 19.1.0
resolution: "@types/react@npm:19.1.0"
dependencies:
"@types/prop-types": "*"
csstype: ^3.0.2
checksum: 9224ef319a0c2b7f66e7e7f06012aa5eb638a6c76c9742843eab1a5d243f2bed5ff829ddbb41efd60d33a266420528adfcb84cb93f238b00e905f98c3a355768
checksum: 7dd7e021897509a68672ab38c268d2f1f519306ade66cc12ffce4dd46e9d2b4224ab49e0b1191b17ac5eceafc65d76e987d6c5b0679224ddbb46f8debce5decc
languageName: node
linkType: hard

Expand Down Expand Up @@ -14046,8 +14045,8 @@ __metadata:
"@types/jest": 29.5.14
"@types/json-bigint": ^1.0.4
"@types/node": ^18.16.9
"@types/react": 18.3.1
"@types/react-dom": 18.3.0
"@types/react": 19.1.0
"@types/react-dom": 19.1.0
"@types/xxhashjs": ^0.2.4
"@typescript-eslint/eslint-plugin": 7.16.0
"@typescript-eslint/parser": 7.16.0
Expand Down Expand Up @@ -14083,8 +14082,8 @@ __metadata:
next: 14.2.5
nx: 20.5.0
prettier: ^3.5.3
react: 18.3.1
react-dom: 18.3.1
react: 19.1.0
react-dom: 19.1.0
react-ga4: ^2.1.0
react-i18next: ^13.3.1
react-markdown: ^8.0.5
Expand Down Expand Up @@ -17599,7 +17598,7 @@ __metadata:
languageName: node
linkType: hard

"loose-envify@npm:^1.1.0, loose-envify@npm:^1.4.0":
"loose-envify@npm:^1.4.0":
version: 1.4.0
resolution: "loose-envify@npm:1.4.0"
dependencies:
Expand Down Expand Up @@ -20704,15 +20703,14 @@ __metadata:
languageName: node
linkType: hard

"react-dom@npm:18.3.1":
version: 18.3.1
resolution: "react-dom@npm:18.3.1"
"react-dom@npm:19.1.0":
version: 19.1.0
resolution: "react-dom@npm:19.1.0"
dependencies:
loose-envify: ^1.1.0
scheduler: ^0.23.2
scheduler: ^0.26.0
peerDependencies:
react: ^18.3.1
checksum: 298954ecd8f78288dcaece05e88b570014d8f6dce5db6f66e6ee91448debeb59dcd31561dddb354eee47e6c1bb234669459060deb238ed0213497146e555a0b9
react: ^19.1.0
checksum: 1d154b6543467095ac269e61ca59db546f34ef76bcdeb90f2dad41d682cd210aae492e70c85010ed5d0a2caea225e9a55139ebc1a615ee85bf197d7f99678cdf
languageName: node
linkType: hard

Expand Down Expand Up @@ -20896,12 +20894,10 @@ __metadata:
languageName: node
linkType: hard

"react@npm:18.3.1":
version: 18.3.1
resolution: "react@npm:18.3.1"
dependencies:
loose-envify: ^1.1.0
checksum: a27bcfa8ff7c15a1e50244ad0d0c1cb2ad4375eeffefd266a64889beea6f6b64c4966c9b37d14ee32d6c9fcd5aa6ba183b6988167ab4d127d13e7cb5b386a376
"react@npm:19.1.0":
version: 19.1.0
resolution: "react@npm:19.1.0"
checksum: c0905f8cfb878b0543a5522727e5ed79c67c8111dc16ceee135b7fe19dce77b2c1c19293513061a8934e721292bfc1517e0487e262d1906f306bdf95fa54d02f
languageName: node
linkType: hard

Expand Down Expand Up @@ -22027,12 +22023,10 @@ __metadata:
languageName: node
linkType: hard

"scheduler@npm:^0.23.2":
version: 0.23.2
resolution: "scheduler@npm:0.23.2"
dependencies:
loose-envify: ^1.1.0
checksum: 3e82d1f419e240ef6219d794ff29c7ee415fbdc19e038f680a10c067108e06284f1847450a210b29bbaf97b9d8a97ced5f624c31c681248ac84c80d56ad5a2c4
"scheduler@npm:^0.26.0":
version: 0.26.0
resolution: "scheduler@npm:0.26.0"
checksum: c63a9f1c0e5089b537231cff6c11f75455b5c8625ae09535c1d7cd0a1b0c77ceecdd9f1074e5e063da5d8dc11e73e8033dcac3361791088be08a6e60c0283ed9
languageName: node
linkType: hard

Expand Down
Loading