Schema urgent fixes #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ResultsetInstance` was missing the "type" parameter which leads to errors when creating instances.
This is a pure documentation change for the handover format. Addresses #83
mbaudis
approved these changes
Jun 12, 2023
|
@costero-e Fine with me 👍 But generally I'd like to see such non-breaking patch fixes then also propagated to |
|
True @mbaudis, as they are hotfixes I guess we can make the PR right direct to main the next time. If you have any urgency for having them in main branch soon we can PR to main branch, too. |
|
@costero-e I'll leave this to you; an important aspect is to have a branch manager w/ "decision power" :-) (But esp. for the filters doc & the missing object type it is rather important and no downside to have it ASAP; the age part is potentially breaking though nobody should care) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch of mixed fixes that can be done straight forward to develop branch because they don't belong to any specific feature. Between those fixes, we can find Handover fix for avoid the verifier to pass beacon tests, adding object type to beacon resultsets, un update in Changelog.md and removing "age" to be a title of diseases.