Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema urgent fixes #85

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed

* Fixed `POST`queries for `g_variant` (w/ examples)
* Removed 'json' references inside the yaml version (PR [#43] (https://github.com/ga4gh-beacon/beacon-v2/pull/43))
* Removed 'json' references inside the yaml version (PR [#43](https://github.com/ga4gh-beacon/beacon-v2/pull/43))
* added missing `type: object` to `ResultsetInstance` (PR [#82](https://github.com/ga4gh-beacon/beacon-v2/pull/82))

### Deprecated

Expand Down
14 changes: 9 additions & 5 deletions framework/json/common/beaconCommonComponents.json
Original file line number Diff line number Diff line change
Expand Up @@ -111,15 +111,19 @@
},
"HandoverType": {
"$ref": "./ontologyTerm.json",
"description": "Handover type, as an Ontology_term object with CURIE syntax for the `id` value. Use `CUSTOM` for the `id` when no ontology is available.",
"description": "Handover type, as an Ontology_term object with CURIE syntax for the `id` value. Use \"CUSTOM:123455\" CURIE-style `id` when no ontology is available.",
"examples": [
{
"id": "EFO:0004157",
"label": "BAM format"
"id": "EDAM:2572",
"label": "BAM"
},
{
"id": "CUSTOM",
"label": "download genomic variants in .pgxseg file format"
"id": "EDAM:3016",
"label": "VCF"
},
{
"id": "CUSTOM:pgxseg",
"label": "genomic variants in .pgxseg file format"
}
]
},
Expand Down
3 changes: 2 additions & 1 deletion framework/json/responses/sections/beaconResultsets.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@
"exists",
"resultsCount",
"results"
]
],
"type": "object"
}
},
"description": "Sets of results to be returned as query response.",
Expand Down
14 changes: 8 additions & 6 deletions framework/src/common/beaconCommonComponents.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -265,11 +265,13 @@ definitions:
example: https://api.mygenomeservice.org/Handover/9dcc48d7-fc88-11e8-9110-b0c592dbf8c0/
HandoverType:
description: >-
Handover type, as an Ontology_term object with CURIE syntax for the `id` value.
Use `CUSTOM` for the `id` when no ontology is available.
Handover type, as an Ontology_term object with CURIE syntax for the `id`
value. Use "CUSTOM:123455" CURIE-style `id` when no ontology is available.
$ref: ./ontologyTerm.yaml
examples:
- id: EFO:0004157
label: BAM format
- id: CUSTOM
label: download genomic variants in .pgxseg file format
- id: EDAM:2572
label: BAM
- id: EDAM:3016
label: VCF
- id: CUSTOM:pgxseg
label: genomic variants in .pgxseg file format
1 change: 1 addition & 0 deletions framework/src/responses/sections/beaconResultsets.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ required:
additionalProperties: true
definitions:
ResultsetInstance:
type: object
properties:
id:
description: id of the resultset
Expand Down
26 changes: 9 additions & 17 deletions models/json/beacon-v2-default-model/common/disease.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,30 +6,22 @@
"$ref": "./timeElement.json",
"examples": [
{
"ageGroup": {
"id": "NCIT:C49685",
"label": "Adult 18-65 Years Old"
}
"id": "NCIT:C49685",
"label": "Adult 18-65 Years Old"
},
{
"age": {
"iso8601duration": "P32Y6M1D"
}
"iso8601duration": "P32Y6M1D"
},
{
"ageRange": {
"end": {
"iso8601duration": "P59Y"
},
"start": {
"iso8601duration": "P18Y"
}
"end": {
"iso8601duration": "P59Y"
},
"start": {
"iso8601duration": "P18Y"
}
},
{
"age": {
"iso8601duration": "P2M4D"
}
"iso8601duration": "P2M4D"
}
]
},
Expand Down
20 changes: 8 additions & 12 deletions models/src/beacon-v2-default-model/common/disease.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,18 +20,14 @@ properties:
ageOfOnset:
$ref: ./timeElement.yaml
examples:
- ageGroup:
id: NCIT:C49685
label: Adult 18-65 Years Old
- age:
iso8601duration: P32Y6M1D
- ageRange:
start:
iso8601duration: P18Y
end:
iso8601duration: P59Y
- age:
iso8601duration: P2M4D
- id: NCIT:C49685
label: Adult 18-65 Years Old
- iso8601duration: P32Y6M1D
- start:
iso8601duration: P18Y
end:
iso8601duration: P59Y
- iso8601duration: P2M4D
stage:
description: 'Ontology term from Ontology for General Medical Science (OGMS),
e.g. acute onset (OGMS:0000119). Provenance: GA4GH Phenopackets v2 `Disease.disease_stage`'
Expand Down