fix: genesis history bounded storage #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Crate versions that have been updated:
Runtime version has been increased. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #642 +/- ##
==========================================
- Coverage 65.09% 64.99% -0.10%
==========================================
Files 132 133 +1
Lines 9697 9711 +14
==========================================
Hits 6312 6312
- Misses 3385 3399 +14
☔ View full report in Codecov by Sentry. |
mrq1911
changed the title
apopiak
reviewed
Jul 25, 2023
| weights::Weight, | ||
| }; | ||
|
|
||
| // This migration fixes the corrupted value in the storage and fixes it |
There was a problem hiding this comment.
so the current values are not correct?
There was a problem hiding this comment.
Yes. We manually set the storage value to something, but the storage has different data type.
|
looks fine except that I don't feel I can judge whether the genesis hash migration stuff is correct |
mrq1911
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
without_storage_infofrom the genesis history pallet and adds a storage migration fixing the corrupted storage value.