-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: genesis history bounded storage #642
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
69d67a3
remove `without_storage_info` macro and add migration
Roznovjak 5ad506d
Merge branch 'master' into genesis_history_bounded_storage
Roznovjak 83e8be0
use correct genesis hash
Roznovjak ec3fed0
ci: using github runner
mrq1911 63b0c95
ci: back to lark
mrq1911 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
[package] | ||
name = "pallet-genesis-history" | ||
version = "2.0.1" | ||
version = "2.1.0" | ||
description = "Keeping track of the past chain generations." | ||
authors = ["GalacticCouncil <[email protected]>"] | ||
edition = "2021" | ||
|
@@ -23,9 +23,7 @@ sp-io = { workspace = true } | |
sp-runtime = { workspace = true } | ||
sp-std = { workspace = true } | ||
sp-core = { workspace = true } | ||
|
||
[dev-dependencies] | ||
hex-literal = '0.3.4' | ||
hex-literal = "0.4.1" | ||
|
||
[features] | ||
default = ['std'] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
// This file is part of pallet-genesis-history | ||
|
||
// Copyright (C) 2020-2023 Intergalactic, Limited (GIB). | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License.. | ||
|
||
pub use crate::*; | ||
pub use frame_support::{ | ||
log, | ||
traits::{Get, StorageVersion}, | ||
weights::Weight, | ||
}; | ||
|
||
// This migration fixes the corrupted value in the storage and fixes it | ||
pub mod v1 { | ||
use super::*; | ||
use hex_literal::hex; | ||
|
||
pub fn pre_migrate<T: Config>() { | ||
assert_eq!(StorageVersion::get::<Pallet<T>>(), 0, "Storage version too high."); | ||
|
||
log::info!( | ||
target: "runtime::genesis-history", | ||
"Genesis history migration: PRE checks successful!" | ||
); | ||
} | ||
|
||
pub fn migrate<T: Config>() -> Weight { | ||
log::info!( | ||
target: "runtime::genesis-history", | ||
"Running migration to v1 for Genesis history" | ||
); | ||
|
||
PreviousChain::<T>::put(Chain { | ||
genesis_hash: H256::from(hex!("d2a620c27ec5cbc5621ff9a522689895074f7cca0d08e7134a7804e1a3ba86fc")), | ||
last_block_hash: H256::from(hex!("1c83220b0d0c0c252dddd6a98c9b643e34625419b646c4a6447583c92c01dbcc")), | ||
}); | ||
|
||
StorageVersion::new(1).put::<Pallet<T>>(); | ||
|
||
T::DbWeight::get().reads_writes(0, 2) | ||
} | ||
|
||
pub fn post_migrate<T: Config>() { | ||
assert_eq!(StorageVersion::get::<Pallet<T>>(), 1, "Unexpected storage version."); | ||
assert_eq!( | ||
PreviousChain::<T>::get(), | ||
Chain { | ||
genesis_hash: H256::from(hex!("d2a620c27ec5cbc5621ff9a522689895074f7cca0d08e7134a7804e1a3ba86fc")), | ||
last_block_hash: H256::from(hex!("1c83220b0d0c0c252dddd6a98c9b643e34625419b646c4a6447583c92c01dbcc")), | ||
}, | ||
"Unexpected storage version." | ||
); | ||
|
||
log::info!( | ||
target: "runtime::genesis-history", | ||
"Genesis history migration: POST checks successful!" | ||
); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so the current values are not correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. We manually set the storage value to something, but the storage has different data type.