RgbdCameraSensor: add missing include #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include gz/msgs/PointCloudPackedUtils.hh for gz::msgs::InitPointCloudPacked. Signed-off-by: Steve Peters <[email protected]>
shameekganguly
approved these changes
Aug 25, 2024
There was a problem hiding this comment.
Thanks Steve, please consider also adding the include in https://github.com/gazebosim/gz-sensors/blob/gz-sensors8/src/DepthCameraSensor.cc, where we also use msgs::InitPointCloudPacked
DepthCameraSensor and GpuLidarSensor also use InitPointCloudPacked so include the header there too. Signed-off-by: Steve Peters <[email protected]>
thanks; I've added the missing header to DepthCameraSensor and also GpuLidarSensor in 80f07cb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes clang-tidy missing include complaint
Summary
Include
gz/msgs/PointCloudPackedUtils.hhforgz::msgs::InitPointCloudPacked.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.