Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add kernel thinning to benchmarking #927

Merged
merged 18 commits into from
Jan 30, 2025
Merged

Feature/add kernel thinning to benchmarking #927

merged 18 commits into from
Jan 30, 2025

Conversation

qh681248
Copy link
Contributor

@qh681248 qh681248 commented Jan 17, 2025 •
edited
Loading

PR Type

  • Feature

Description

Added Kernel Thinning to existing benchmarking tests

How Has This Been Tested?

Existing tests pass as expected.

No new tests have been added

Does this PR introduce a breaking change?

Checklist before requesting a review

  • I have made sure that my PR is not a duplicate.
  • My code follows the style guidelines of this project.
  • I have ensured my code is easy to understand, including docstrings and comments where necessary.
  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have updated CHANGELOG.md, if appropriate.

@github-actions GitHub Actions
Copy link
Contributor

Performance review

Commit 03ba667 - Merge 665baf9 into af0e579

No significant changes to performance.

@github-actions GitHub Actions
Copy link
Contributor

Performance review

Commit f56f2c9 - Merge 640bf4d into c5e090d

No significant changes to performance.

@qh681248 qh681248 linked an issue Jan 20, 2025 that may be closed by this pull request
Include KT in benchmarking #919
Closed
@bk958178 bk958178 self-requested a review January 22, 2025 17:00
@rg936672 rg936672 mentioned this pull request Jan 23, 2025
Closed
9 tasks
@rg936672 rg936672 self-requested a review January 28, 2025 12:23
rg936672
rg936672 requested changes Jan 28, 2025
View reviewed changes
benchmark/blobs_benchmark.py Show resolved Hide resolved
benchmark/david_benchmark.py Outdated Show resolved Hide resolved
benchmark/mnist_benchmark.py Outdated Show resolved Hide resolved
benchmark/mnist_benchmark.py Outdated Show resolved Hide resolved
benchmark/mnist_benchmark.py Outdated Show resolved Hide resolved
examples/benchmarking_images/david_benchmark_results.png Outdated Show resolved Hide resolved
examples/benchmarking_images/mnist_benchmark_time_taken.png Outdated Show resolved Hide resolved
tests/unit/test_solvers.py Outdated Show resolved Hide resolved
tests/unit/test_solvers.py Outdated Show resolved Hide resolved
tests/unit/test_solvers.py Outdated Show resolved Hide resolved
@qh681248 qh681248 requested a review from rg936672 January 29, 2025 12:27
@github-actions GitHub Actions
Copy link
Contributor

Performance review

Commit 41df279 - Merge d2c5c2c into 4b4aed5

No significant changes to performance.

@github-actions GitHub Actions
Copy link
Contributor

Performance review

Commit 0255280 - Merge 2df0ce7 into 4b4aed5

No significant changes to performance.

@github-actions GitHub Actions
Copy link
Contributor

Performance review

Commit 37e2146 - Merge f23a7d1 into 4b4aed5

No significant changes to performance.

@github-actions GitHub Actions
Copy link
Contributor

Performance review

Commit 7aee031 - Merge bd297a2 into 4b4aed5

No significant changes to performance.

rg936672
rg936672 requested changes Jan 30, 2025
View reviewed changes
benchmark/blobs_benchmark.py Outdated Show resolved Hide resolved
benchmark/mnist_benchmark_visualiser.py Outdated Show resolved Hide resolved
tests/unit/test_benchmark.py Outdated Show resolved Hide resolved
tests/unit/test_benchmark.py Outdated Show resolved Hide resolved
coreax/benchmark_util.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Performance review

Commit 3964788 - Merge d57524a into 4b4aed5

No significant changes to performance.

@qh681248 qh681248 requested a review from rg936672 January 30, 2025 11:09
@qh681248 qh681248 merged commit cc6a510 into main Jan 30, 2025
20 checks passed
@qh681248 qh681248 deleted the feature/add-kernel-thinning-to-benchmarking branch January 30, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rg936672 rg936672 rg936672 approved these changes

@bk958178 bk958178 Awaiting requested review from bk958178

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include KT in benchmarking
2 participants
@qh681248 @rg936672