chore(deps): Bump Microsoft.CodeAnalysis.CSharp and Microsoft.CodeAnalysis.CSharp.Workspaces#186
Conversation
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 16bb545214
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| <!-- Force usage of Roslyn 4.3.0 to match the Analyzer project and resolve conflicts --> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.3.0" /> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.14.0" /> |
There was a problem hiding this comment.
Changing only Microsoft.CodeAnalysis.CSharp here leaves the test project with Microsoft.CodeAnalysis.CSharp.Workspaces still pinned to 4.3.0 on the next line, while Roslyn workspace packages depend on the matching Microsoft.CodeAnalysis.CSharp/Common version. In this state any restore/test of LinqContraband.Tests resolves a mixed 4.14/4.3 Roslyn graph, which can surface as NuGet version-conflict warnings or runtime loader failures in the code-fix tests instead of exercising the same Roslyn stack as the analyzer project. Please bump the Workspaces reference in this project to 4.14.0 as well.
Useful? React with 👍 / 👎.
…lysis.CSharp.Workspaces Bumps Microsoft.CodeAnalysis.CSharp from 4.3.0 to 4.14.0 Bumps Microsoft.CodeAnalysis.CSharp.Workspaces from 4.3.0 to 4.14.0 --- updated-dependencies: - dependency-name: Microsoft.CodeAnalysis.CSharp dependency-version: 4.14.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: Microsoft.CodeAnalysis.CSharp dependency-version: 4.14.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: Microsoft.CodeAnalysis.CSharp.Workspaces dependency-version: 4.14.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
16bb545 to
d66923b
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d66923b3f5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.14.0"> | ||
| <PrivateAssets>all</PrivateAssets> | ||
| </PackageReference> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.3.0"> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.14.0"> |
There was a problem hiding this comment.
Because this analyzer package suppresses NuGet dependencies and only packs LinqContraband.dll, bumping the compiler/workspaces references to 4.14 bakes a Roslyn 4.14 assembly reference into the published analyzer without delivering that Roslyn version. In hosts with an older compiler, such as VS 17.8/.NET 8 or VS 17.12/.NET 9, the analyzer will fail to load instead of reporting diagnostics. Please keep these references at the lowest supported Roslyn host version unless the package intentionally drops older hosts and documents/enforces that floor.
Useful? React with 👍 / 👎.
Updated Microsoft.CodeAnalysis.CSharp from 4.3.0 to 4.14.0.
Release notes
Sourced from Microsoft.CodeAnalysis.CSharp's releases.
No release notes found for this version range.
Commits viewable in compare view.
Updated Microsoft.CodeAnalysis.CSharp.Workspaces from 4.3.0 to 4.14.0.