Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/LinqContraband/LinqContraband.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.3.0">
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.14.0">
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.3.0">
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.14.0">
Comment on lines +48 to +51

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep Roslyn references at the supported host floor

Because this analyzer package suppresses NuGet dependencies and only packs LinqContraband.dll, bumping the compiler/workspaces references to 4.14 bakes a Roslyn 4.14 assembly reference into the published analyzer without delivering that Roslyn version. In hosts with an older compiler, such as VS 17.8/.NET 8 or VS 17.12/.NET 9, the analyzer will fail to load instead of reporting diagnostics. Please keep these references at the lowest supported Roslyn host version unless the package intentionally drops older hosts and documents/enforces that floor.

Useful? React with 👍 / 👎.

<PrivateAssets>all</PrivateAssets>
</PackageReference>

Expand Down
Loading