Add AABB::from_center utility constructor#222
Merged
adamreichold merged 1 commit intomasterfrom Feb 26, 2026
Merged
Conversation
urschrei
approved these changes
Feb 26, 2026
michaelkirk
reviewed
Feb 27, 2026
| } | ||
|
|
||
| /// Creates a new AABB from a center and a diameter. | ||
| pub fn from_center(center: P, diameter: P::Scalar) -> Self { |
Member
There was a problem hiding this comment.
Would "width" be better? I feel like "diameter"/"radius" cannotes a circle.
Member
Author
There was a problem hiding this comment.
I did wonder about this back and forth because of the connotation. I stuck with diameter as it makes it explicit that extent is measured end-to-end instead of from the centre. (And it is an L∞ circle after all... ;))
Since this is unreleased, we can still change it. I wonder if we should expose an distance: P::Scalar parameter and actually remove the / (one + one) computation from the method? The caller presumably knows best whether to half the value and what its interpretation is?
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rstar/CHANGELOG.mdif knowledge of this change could be valuable to users.Closes #46