Add Customization Options for Payment Methods in Payment Request Modal #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Break the component structure in multipe composable parts.
The new property can have three values: all, internal or external. Internal payment methods refer to "connect" buttons. External payment methods refer to "show QR/Copy Invoice" All payment methods refer to show Internal and External options. For mobile, the "Open in a Bitcoin Wallet" is always available.
|
Hi @positiveblue , thanks for your PR! I was unable to edit your branch so I have made some improvements here: #214 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature that allows customization of the payment methods displayed in the payment request modal.
The bc-send-payment component now accepts a
paymentMethodsproperty, which can be set toall(default),internal, orexternalinternal: Shows only the internal payment methods (connecting a wallet).
external: Displays only the external payment methods (QR code and invoice).
all: Displays both internal payment methods (connecting a wallet) and external payment methods (QR code and invoice).
The layout and spacing of the payment methods have been adjusted to ensure a consistent and visually appealing design, regardless of the selected payment options.
To use this feature, set the
payment-methodsproperty on thebc-send-paymentcomponent to the desired value:The changes have been added to the
dev/vitaindex, so you can see the results by runningyarn dev.Fix #212