Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add payment methods #214

Merged
merged 7 commits into from
May 3, 2024
Merged

Feat: add payment methods #214

merged 7 commits into from
May 3, 2024

Conversation

rolznz
Copy link
Collaborator

@rolznz rolznz commented May 1, 2024 •
edited
Loading

New PR based off of #213

Fixes #212

  • Add React wrapper support

Try it by installing @getalby/[email protected] or @getalby/[email protected]

positiveblue and others added 4 commits April 29, 2024 21:23
@positiveblue
react bc-send-payment: refactor component render
8ba2e69 
Break the component structure in multipe composable parts.
@positiveblue
react bc-send-payment: add payment-methods property
3b9b7c5 
The new property can have three values: all, internal or external.

Internal payment methods refer to "connect" buttons.
External payment methods refer to "show QR/Copy Invoice"
All payment methods refer to show Internal and External options.

For mobile, the "Open in a Bitcoin Wallet" is always available.
@positiveblue
script: npm run format
19705f4
@rolznz
feat: improve payment methods support
12a47c3 
- only show mobile open in wallet button with correct payment methods
- add payment methods to bc-payment component
- add payment methods option to pay button
- add payment methods option to launch payment modal function
- add payment methods option to dev interface and apply to all related elements
- minor ui fixes
- update README
@rolznz rolznz mentioned this pull request May 1, 2024
Closed
@socket-security Socket Security
Copy link

socket-security bot commented May 1, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/[email protected] None +3 99.7 kB nicolo-ribaudo
npm/@babel/[email protected] None +1 518 kB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, unsafe +10 1.73 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, unsafe +14 1.94 MB nicolo-ribaudo
npm/@babel/[email protected] None 0 3.72 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, unsafe +9 1.71 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, unsafe +8 1.77 MB nicolo-ribaudo
npm/@babel/[email protected] None +1 310 kB nicolo-ribaudo
npm/@babel/[email protected] None +5 712 kB nicolo-ribaudo
npm/@babel/[email protected] environment +2 2.47 MB nicolo-ribaudo
npm/@getalby/[email protected] network 0 134 kB reneaaron
npm/@jridgewell/[email protected] None +2 259 kB jridgewell
npm/@lit/[email protected] None 0 833 kB lit-robot
npm/@open-wc/[email protected] Transitive: environment, eval, filesystem, network, unsafe +98 11.5 MB modern-web
npm/@twind/[email protected] None +1 4.77 MB sastan
npm/@twind/[email protected] None 0 2.08 MB sastan
npm/@twind/[email protected] None 0 150 kB sastan
npm/@types/[email protected] None 0 77.2 kB types
npm/@types/[email protected] None 0 5.76 kB types
npm/@types/[email protected] None +16 3.98 MB types
npm/@typescript-eslint/[email protected] Transitive: environment, filesystem +16 6.17 MB jameshenry
npm/@typescript-eslint/[email protected] Transitive: environment, filesystem +4 1.4 MB jameshenry
npm/@web/[email protected] filesystem Transitive: environment, eval, network, shell, unsafe +67 218 MB modern-web
npm/@web/[email protected] None +2 379 kB modern-web
npm/@web/[email protected] filesystem, network Transitive: environment, eval, unsafe +83 6.76 MB modern-web
npm/@web/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +4 7.31 MB modern-web
npm/@web/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +100 17.4 MB modern-web
npm/@webbtc/[email protected] None 0 11.4 kB rolznz
npm/@webcomponents/[email protected] None 0 3.56 MB bicknellr
npm/[email protected] environment, filesystem +2 332 kB ai
npm/[email protected] None +2 98.9 kB feross
npm/[email protected] None 0 2.06 MB caniuse-lite
npm/[email protected] environment, filesystem Transitive: shell +6 11.4 MB gustavohenke
npm/[email protected] None 0 6.23 kB mafintosh
npm/[email protected] environment, filesystem, network, shell +22 207 MB evanw
npm/[email protected] None 0 32.3 kB eslintbot
npm/[email protected] environment, filesystem Transitive: eval, shell, unsafe +52 8.91 MB eslintbot
npm/[email protected] None +2 21.4 kB phated
npm/[email protected] filesystem +1 154 kB mrmlnc
npm/[email protected] None 0 3.71 kB jonschlinkert
npm/[email protected] None +2 27.2 kB jonschlinkert
npm/[email protected] None 0 5.09 kB jonschlinkert
npm/[email protected] None 0 7.5 kB jonschlinkert
npm/[email protected] None 0 6.93 kB doowb
npm/[email protected] None 0 22.8 kB doowb
npm/[email protected] filesystem Transitive: environment, network +68 3.08 MB runebm
npm/[email protected] None 0 1.66 MB lit-robot
npm/[email protected] None 0 105 kB lit-robot
npm/[email protected] environment, filesystem, unsafe 0 11.2 MB prettier-bot
npm/[email protected] environment +1 138 kB matteo.collina
npm/[email protected] None +2 32.2 kB jonschlinkert
npm/[email protected] environment, filesystem +4 206 kB ljharb
npm/[email protected] None 0 10.3 kB doowb
npm/[email protected] None 0 13.8 kB jonschlinkert

🚮 Removed packages: npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@eslint-community/[email protected], npm/@getalby/[email protected], npm/@getalby/[email protected], npm/@jridgewell/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@vitejs/[email protected], npm/@webbtc/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@socket-security Socket Security
Copy link

socket-security bot commented May 1, 2024 •
edited
Loading

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/[email protected]
  • Install script: install
  • Source: node install.js

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@rolznz
Copy link
Collaborator Author

rolznz commented May 1, 2024

I realized it doesn't really make sense to pass it as a property? it might be better as a global bitcoin connect option... I don't know if there will be any app which requires this to be different in different situations.

@rolznz
Copy link
Collaborator Author

rolznz commented May 1, 2024

@positiveblue do my changes look ok to you? if so I'll merge it

@positiveblue
Copy link
Contributor

positiveblue commented May 2, 2024 •
edited
Loading

@rolznz we tested it using the 3.3.0-beta.3 pkg and it went well, feel free to merge 🚀

Thank you!

@rolznz rolznz merged commit 784db8c into master May 3, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove external payment options from payment request modal
2 participants
@rolznz @positiveblue