Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry Support #853

Closed
wants to merge 9 commits into from
Closed

OpenTelemetry Support #853

wants to merge 9 commits into from

Conversation

solnic
Copy link
Collaborator

@solnic solnic commented Jan 27, 2025

This is a small rework of #784 on top of #842 (that got merged).


Tasks

  • Figure out why tests are failing here
  • Finalize support for Phoenix
  • Finalize support for Oban
  • Finalize support for Ecto
  • Figure out how parent/children spans should be passed as Transactions when span processor captures only a single root span
  • Test it out in a real app

@solnic solnic changed the title Solnic/opentelemetry-support OpenTelemetry Support Jan 27, 2025
@solnic solnic force-pushed the solnic/opentelemetry-support branch from 3b6d007 to 65918e5 Compare January 27, 2025 12:48
@solnic
Copy link
Collaborator Author

solnic commented Jan 27, 2025

@whatyouhide here we go again - do we want to narrow down the scope of this to ship it in smaller chunks, or do we want an all-in approach? :)

@solnic solnic force-pushed the solnic/opentelemetry-support branch from 63dc6e3 to 74100e9 Compare March 12, 2025 13:55
@solnic
Copy link
Collaborator Author

solnic commented Mar 12, 2025

@stephanie-anderson @whatyouhide @sl0thentr0py hey hey, gonna pick it up again. I added a (very high-level) todo. Please chime in if you'd like to reduce the scope here.

@whatyouhide
Copy link
Collaborator

whatyouhide commented Mar 14, 2025

I would 100% go with smaller chunks here. We need to PoC this to see how well it scales and all, and I don't think going all in is going to make that easy.

@whatyouhide
Copy link
Collaborator

I would also split up PRs that change integration tests because a 2k+/0- diff is not easy to review in too much detail 😉

@solnic
Copy link
Collaborator Author

solnic commented Mar 14, 2025

Closing this in favor of #875

@solnic solnic closed this Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants