-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SpanProcessor for OpenTelemetry #875
base: master
Are you sure you want to change the base?
Conversation
0ebd132
to
dee9540
Compare
@whatyouhide ☝🏻 I'm having trouble figuring out these failures. Could you tell me how I could debug what exactly causes the :sentry app startup failure? We start it manually in the umbrella test helpers and for whatever reason it started failing when opentelemetry is included. |
Adding just the OTel deps without any other changes leads to the same issue? |
please write some minimal description in the PR about
|
@whatyouhide @sl0thentr0py I narrowed it down to |
@whatyouhide for the time being I addressed it by using optional deps for otel packages via 6fdf121 but then one of the tests in event_test.exs started to fail so I fixed it via d04c5d3 even though I don't understand what's going on there 🙃 |
@solnic is this ready for review? It's still a draft |
Not yet. I got it working but phoenix + bandit spans are not processed in a way that would make sense for Sentry for some reason. I've been investigating how to fix. It seems like phoenix spans are not coming in as children of bandit spans so there's a disconnect here. I'll figure it out 🙂 |
If we're just shipping a We will revisit packaging later once we have a proper working prototype. |
b2ad0c1
to
456eb45
Compare
b607ac1
to
bdcc5de
Compare
@sl0thentr0py @whatyouhide this is now open for reviews. I got it deployed to production already and it's working well (see screenshots in the description). |
To make this work you need to add opentelemetry deps:
Then configure our span processor:
Things should start looking more or less like this: