Skip to content

Commit

Permalink
ref(core): Cleanup internal types
Browse files Browse the repository at this point in the history
  • Loading branch information
mydea committed Dec 30, 2024
1 parent 9030f37 commit 2b01487
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 11 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"circularDepCheck": "lerna run circularDepCheck",
"clean": "run-s clean:build clean:caches",
"clean:build": "lerna run clean",
"clean:caches": "yarn rimraf eslintcache .nxcache && yarn jest --clearCache",
"clean:caches": "yarn rimraf eslintcache .nxcache .nx && yarn jest --clearCache",
"clean:deps": "lerna clean --yes && rm -rf node_modules && yarn",
"clean:tarballs": "rimraf {packages,dev-packages}/*/*.tgz",
"clean:watchman": "watchman watch-del \".\"",
Expand Down
3 changes: 1 addition & 2 deletions packages/browser-utils/src/metrics/inp.ts
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,8 @@ function _trackINP(): () => void {

/**
* Register a listener to cache route information for INP interactions.
* TODO(v9): `latestRoute` no longer needs to be passed in and will be removed in v9.
*/
export function registerInpInteractionListener(_latestRoute?: unknown): void {
export function registerInpInteractionListener(): void {
const handleEntries = ({ entries }: { entries: PerformanceEntry[] }): void => {
const activeSpan = getActiveSpan();
const activeRootSpan = activeSpan && getRootSpan(activeSpan);
Expand Down
4 changes: 1 addition & 3 deletions packages/browser/src/sdk.ts
Original file line number Diff line number Diff line change
Expand Up @@ -198,9 +198,7 @@ export function init(browserOptions: BrowserOptions = {}): Client | undefined {
* All properties the report dialog supports
*/
export interface ReportDialogOptions {
// TODO(v9): Change this to [key: string]: unknkown;
// eslint-disable-next-line @typescript-eslint/no-explicit-any
[key: string]: any;
[key: string]: unknown;
eventId?: string;
dsn?: DsnLike;
user?: {
Expand Down
4 changes: 1 addition & 3 deletions packages/core/src/api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,7 @@ export function getEnvelopeEndpointWithUrlEncodedAuth(dsn: DsnComponents, tunnel
export function getReportDialogEndpoint(
dsnLike: DsnLike,
dialogOptions: {
// TODO(v9): Change this to [key: string]: unknown;
// eslint-disable-next-line @typescript-eslint/no-explicit-any
[key: string]: any;
[key: string]: unknown;
user?: { name?: string; email?: string };
},
): string {
Expand Down
2 changes: 0 additions & 2 deletions packages/core/src/types-hoist/wrappedfunction.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
*/
// eslint-disable-next-line @typescript-eslint/ban-types
export type WrappedFunction<T extends Function = Function> = T & {
// TODO(v9): Remove this
[key: string]: any;
__sentry_wrapped__?: WrappedFunction<T>;
__sentry_original__?: T;
};

0 comments on commit 2b01487

Please sign in to comment.