-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(solidstart)!: Default to --import
setup and add autoInjectServerSentry
#14862
Open
s1gr1d
wants to merge
14
commits into
develop
Choose a base branch
from
ab/solidstart-withsentry
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,755
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instrumentation files
s1gr1d
changed the title
Ab/solidstart withsentry
feat(solidstart)!: Default to --import setup and add Dec 30, 2024
autoInjectServerSentry
s1gr1d
changed the title
feat(solidstart)!: Default to --import setup and add
feat(solidstart)!: Default to Dec 30, 2024
autoInjectServerSentry
--import
setup and add autoInjectServerSentry
s1gr1d
force-pushed
the
ab/solidstart-withsentry
branch
from
December 30, 2024 14:22
e7b59a0
to
b402fe1
Compare
❌ 3 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
withSentry
wrapper for SolidStart's config to build and placeinstrument.server.ts
alongside the server build output so that it doesn't have to be placed in/public
anymore to be discoverable.The setup is changed to be aligned with Nuxt.
First, the
instrument.server.ts
file is added to the build output (the sentry release injection file needs to be copied as well - this is not ideal at the moment as there could be other imports as well, but it's okay for now)Then, there are two options to set up the SDK:
--import
CLI flag to their start command like this:node --import ./.output/server/instrument.server.mjs .output/server/index.mjs
autoInjectServerSentry: 'top-level-import'
and the Sentry config will be imported at the top of the server entrybuilds on top of the idea in this PR: #13784