Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev container setup #2576

Merged
merged 1 commit into from
Mar 14, 2025
Merged

Conversation

solnic
Copy link
Collaborator

@solnic solnic commented Mar 10, 2025

Addressing feedback from @st0012 with this PR:

You mentioned that the VS Code command is called Remote-Containers: Reopen in Container, but I did find it and ended up using this instead. I wonder what's causing the difference 🤔

If you didn't have the project opened as a workspace, then it probably caused it?

Screenshot 2025-03-08 at 22 55 35
How did you pull your local shell configs...etc. into the container? I currently don't see a way to do it and it makes the terminal in the container hard to use 😢

VS Code has built-in support for dotfiles stored on github, so I just use that, it's been a game changer for me :)

See here https://code.visualstudio.com/docs/devcontainers/containers#_personalizing-with-dotfile-repositories

I noticed that the top-level folder is sentry instead of sentry-ruby, which fails some tests (see below). Do you want to update the config to use sentry-ruby as the root instead?

This PR changes the dir, specs are passing now, thanks for spotting this 🙇🏻

Ruby LSP doesn't run with the current setting as the container doesn't use any Ruby version manager and the devcontainer setting doesn't specify sufficient settings as an alternative. How do you make it work?

This PR sets version manager to none and it seems to be working.

#skip-changelog

- Use /workspace/sentry-ruby as appearently it's needed for specs to pass
- Set Ruby version manager to "none" for Ruby LSP because it doesn't figure it out by itself
@solnic solnic marked this pull request as ready for review March 10, 2025 14:47
@solnic solnic requested review from st0012 and sl0thentr0py March 10, 2025 14:47
@solnic solnic merged commit cf3887b into master Mar 14, 2025
135 of 136 checks passed
@solnic solnic deleted the solnic/update-dev-container-setup branch March 14, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants