Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev container setup #2576

Merged
merged 1 commit into from
Mar 14, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update dev container setup
- Use /workspace/sentry-ruby as appearently it's needed for specs to pass
- Set Ruby version manager to "none" for Ruby LSP because it doesn't figure it out by itself
solnic committed Mar 10, 2025
commit abcbf2c79b90ee406b4dcfa781dffc3d3a5b39e0
8 changes: 6 additions & 2 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -2,13 +2,17 @@
"name": "sentry-ruby",
"dockerComposeFile": "docker-compose.yml",
"service": "app",
"workspaceFolder": "/workspace/sentry",
"workspaceFolder": "/workspace/sentry-ruby",
"customizations": {
"vscode": {
"extensions": [
"sleistner.vscode-fileutils",
"Shopify.ruby-lsp"
]
],
"settings": {}
},
"rubyLsp.rubyVersionManager": {
"identifier": "none"
}
},
"remoteUser": "sentry",
2 changes: 1 addition & 1 deletion .devcontainer/docker-compose.yml
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ services:
IMAGE: ${IMAGE}
TAG: ${TAG}
volumes:
- ..:/workspace/sentry:cached
- ..:/workspace/sentry-ruby:cached
command: sleep infinity
environment:
- REDIS_URL=${REDIS_URL:-redis://redis:6379/0}