feat(insights): score ring and breakdown chart drop missing vital segments #82686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
…andle-missing-webvitals
…andle-missing-webvitals
gggritso
approved these changes
Jan 2, 2025
.../insights/browser/webVitals/queries/storedScoreQueries/getWebVitalScoresFromTableDataRow.tsx
Outdated
Show resolved
Hide resolved
…andle-missing-webvitals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in the Web Vitals module, if a specific vital is never reported in the organization or project, we just assume that the score of the vital is 0. However, this is misleading to the user, since the score is not actually 0.
Instead, we want to handle missing vitals by excluding them from and score calculation. This means dropping missing vitals from the score ring and rebalancing the score breakdown timeseries in the frontend.
note: the 37 score should actually be ~60. This will be fixed by the following backend pr