chore: Enable a few eslint rules that overlap with biomes rule list

[ryan953]

Looking at our biome config here we can see all the linty rules that are enabled for JavaScript files:

sentry/biome.json

Lines 14 to 87 in fc9ccb0

	"rules": {
	"recommended": false,
	"a11y": {
	"noBlankTarget": "error"
	},
	"correctness": {
	"noGlobalObjectCalls": "error",
	"noUnreachable": "error",
	"useIsNan": "error",
	"noUnusedPrivateClassMembers": "error",
	"noInvalidUseBeforeDeclaration": "error",
	"noNodejsModules": "error"
	},
	"complexity": {
	"useFlatMap": "error",
	"useOptionalChain": "error",
	"noEmptyTypeParameters": "error",
	"noUselessLoneBlockStatements": "error",
	"noUselessEmptyExport": "error",
	"noUselessConstructor": "error",
	"noUselessTypeConstraint": "error",
	"noExcessiveNestedTestSuites": "error"
	},
	"nursery": {
	"noRestrictedImports": {
	"level": "warn",
	"options": {
	"paths": {}
	}
	}
	},
	"performance": {
	"noBarrelFile": "error"
	},
	"security": {
	"noDangerouslySetInnerHtmlWithChildren": "error"
	},
	"suspicious": {
	"noDebugger": "error",
	"noDoubleEquals": "error",
	"noDuplicateJsxProps": "error",
	"noDuplicateObjectKeys": "error",
	"noDuplicateParameters": "error",
	"noDuplicateCase": "error",
	"noFallthroughSwitchClause": "error",
	"noRedeclare": "error",
	"noSparseArray": "error",
	"noUnsafeDeclarationMerging": "error",
	"noUnsafeNegation": "error",
	"useIsArray": "error",
	"noApproximativeNumericConstant": "error",
	"noMisrefactoredShorthandAssign": "error",
	"useAwait": "error",
	"useNamespaceKeyword": "error",
	"noFocusedTests": "error",
	"noDuplicateTestHooks": "error"
	},
	"style": {
	"noCommaOperator": "error",
	"noShoutyConstants": "error",
	"noParameterProperties": "error",
	"noVar": "error",
	"useConst": "error",
	"useShorthandFunctionType": "error",
	"useExportType": "error",
	"useImportType": "error",
	"useNodejsImportProtocol": "error",
	"useLiteralEnumMembers": "error",
	"useEnumInitializers": "error",
	"useAsConstAssertion": "error",
	"useBlockStatements": "error"
	}
	}
	},

The docs provide the name of the equiv rule inside eslint core, or inside other eslint plugins if available. I mapped the names of the biome rules to those eslint rules here (below).

Then I went through each rule and enabled it within the codebase. It was meant to be trivial because biome should've prevented violations, but a few places did need to be fixed up. Anywhere that had a biome-ignore statement needed an eslint one too.

There are still a few rules that biome implements which are not in our eslint config right now. The categories are broadly:

1. Rules from plugins that i haven't installed yet, like from unicorn/* or from barrel-files/*. I'll import these plugins in a followup and check things off the list.
2. Some rules have no eslint equiv: noApproximativeNumericConstant & noMisrefactoredShorthandAssign, they're also not important to have enabled imo
3. Some rules have an eslint equiv but are also not important: noShoutyConstants & noInvalidUseBeforeDeclaration would cause lots of churn in the repo for example. Others are repalced by prettier.
4. Some rules depend on type annotations, these are challenging because they are often nice to have but type annotations are slow in eslint. It would make pre-commit checks really terrible if that was enabled. consistent-type-imports is an example.

I intend to get plugins to fill these specific biome gaps while maintaining pre-commit perf.

---

The rules table is here:

Biome Rule	ESLint Rule	Handled by
noBlankTarget	react/jsx-no-target-blank	✅ react/recommended
noGlobalObjectCalls	no-obj-calls	✅ tsc
noUnreachable	no-unreachable	✅ tsc
useIsNan	use-isnan	✅ eslint/recommended
noUnusedPrivateClassMembers	no-unused-private-class-members	✅ eslint/recommended
noInvalidUseBeforeDeclaration	@typescript-eslint/no-use-before-define	✅ Disabled in sentry
noNodejsModules	import/no-nodejs-modules	✅ eslint.config (except scripts)
useFlatMap	unicorn/prefer-array-flat-map	TODO
useOptionalChain	@typescript-eslint/prefer-optional-chain	TODO typescript/stylistic-type-checked
noEmptyTypeParameters	Prettier?	TODO
noUselessLoneBlockStatements	no-lone-blocks	✅ eslint.config
noUselessEmptyExport	@typescript-eslint/no-useless-empty-export	✅ eslint.config
noUselessConstructor	@typescript-eslint/no-useless-constructor	✅ typescript/strict
noUselessTypeConstraint	@typescript-eslint/no-unnecessary-type-constraint	✅ typescript/recommended
noExcessiveNestedTestSuites	jest/max-nested-describe (max=5)	✅ eslint.config
noBarrelFile	barrel-files/avoid-barrel-files	TODO
noDangerouslySetInnerHtmlWithChildren	react/no-danger-with-children	✅ react/recommended
noDebugger	no-debugger	✅ eslint/recommended
noDoubleEquals	eqeqeq	✅ eslint.config
noDuplicateJsxProps	react/jsx-no-duplicate-props	✅ react/recommended
noDuplicateObjectKeys	no-dupe-keys	✅ tsc
noDuplicateParameters	no-dupe-args	✅ tsc
noDuplicateCase	no-duplicate-case	✅ eslint/recommended
noFallthroughSwitchClause	no-fallthrough	✅ eslint/recommended
noRedeclare	@typescript-eslint/no-redeclare	✅ tsc
noSparseArray	no-sparse-arrays	✅ eslint recommended
noUnsafeDeclarationMerging	@typescript-eslint/no-unsafe-declaration-merging	✅ typescript/recommended
noUnsafeNegation	no-unsafe-negation	✅ tsc
useIsArray	unicorn/no-instanceof-array	TODO
noApproximativeNumericConstant	approx_constant	TODO
noMisrefactoredShorthandAssign	misrefactored_assign_op	TODO
useAwait	require-await & @typescript-eslint/require-await	✅ esint.config
useNamespaceKeyword	@typescript-eslint/prefer-namespace-keyword	✅ typescript/recommended
noFocusedTests	jest/no-focused-tests	✅ jest/recommended
noDuplicateTestHooks	jest/no-duplicate-hooks	✅ eslint.config
noCommaOperator	no-sequences	✅ eslint.config
noShoutyConstants	???	TODO
noParameterProperties	@typescript-eslint/parameter-properties	✅ typescript
noVar	no-var	✅ eslint.config
useConst	prefer-const	✅ tsc
useShorthandFunctionType	@typescript-eslint/prefer-function-type	✅ typescript/stylistic
useExportType	@typescript-eslint/consistent-type-exports	TODO requires types
useImportType	@typescript-eslint/consistent-type-imports	TODO requires types
useNodejsImportProtocol	unicorn/prefer-node-protocol	TODO
useLiteralEnumMembers	@typescript-eslint/prefer-literal-enum-member	✅ typescript/strict
useEnumInitializers	@typescript-eslint/prefer-enum-initializers	✅
useAsConstAssertion	@typescript-eslint/prefer-as-const	✅ typescript/recommended
useBlockStatements	curly	✅ prettier

New plugins:

• https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-array-flat-map.md
• https://github.com/thepassle/eslint-plugin-barrel-files/blob/main/docs/rules/avoid-barrel-files.md
• https://tanstack.com/query/v5/docs/eslint/eslint-plugin-query

[ryan953]

Something formatting it this way.