Skip to content

chore(jira): record workflow errors as halts#88996

Merged
Christinarlong merged 7 commits intomasterfrom
crl/record-jira-workflow-errors-as-halts
May 9, 2025
Merged

chore(jira): record workflow errors as halts#88996
Christinarlong merged 7 commits intomasterfrom
crl/record-jira-workflow-errors-as-halts

Conversation

@Christinarlong
Copy link
Contributor

For Jira specifically, organizations may have setup specific workflows for their Jira boards which restrict us moving an issue from State A to State B unless we fufill X condition.

  • Currently we try and move the issue to the specified state without any extra info. As a result our syncing can fail if we hit one of the above restrictions

    • Example: Org has their Jira board setup that you can't mark an issue as Done unless their custom field Reason field is filled out. We don't give a way for users to modify that Jira issue in Sentry currently. So if a user has syncing setup to mark a Jira issue as Done if Resolved in Sentry, then syncing will fail because they don't have a Reason filled in.
  • An improvement for this could be showing the failure reason via UI ?

  • Also I think we could mark this as halt, since our current Jira integration doesn't have the capability to fix this kind of issue. (Also supporting these workflow restrictions in Sentry would be :despairge: )

  • Corresponding sentry issue: https://sentry.sentry.io/issues/6083715764/events/b4a6349bd3b04467896ebab8cf873a1d/

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 8, 2025
@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/integrations/jira/integration.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #88996       +/-   ##
===========================================
+ Coverage   62.26%   87.64%   +25.37%     
===========================================
  Files       10285    10194       -91     
  Lines      583664   583010      -654     
  Branches    22580    22431      -149     
===========================================
+ Hits       363441   510975   +147534     
+ Misses     219581    71592   -147989     
+ Partials      642      443      -199     

@Christinarlong Christinarlong marked this pull request as ready for review May 5, 2025 16:04
@Christinarlong Christinarlong requested review from a team as code owners May 5, 2025 16:04
Copy link
Collaborator

@iamrajjoshi iamrajjoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Co-authored-by: Raj Joshi <raj.joshi@sentry.io>
@Christinarlong Christinarlong merged commit cd61057 into master May 9, 2025
60 checks passed
@Christinarlong Christinarlong deleted the crl/record-jira-workflow-errors-as-halts branch May 9, 2025 17:44
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants