chore(jira): record workflow errors as halts#88996
Merged
Christinarlong merged 7 commits intomasterfrom May 9, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #88996 +/- ##
===========================================
+ Coverage 62.26% 87.64% +25.37%
===========================================
Files 10285 10194 -91
Lines 583664 583010 -654
Branches 22580 22431 -149
===========================================
+ Hits 363441 510975 +147534
+ Misses 219581 71592 -147989
+ Partials 642 443 -199 |
Co-authored-by: Raj Joshi <raj.joshi@sentry.io>
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Jira specifically, organizations may have setup specific workflows for their Jira boards which restrict us moving an issue from State A to State B unless we fufill X condition.
Currently we try and move the issue to the specified state without any extra info. As a result our syncing can fail if we hit one of the above restrictions
Doneunless their custom fieldReasonfield is filled out. We don't give a way for users to modify that Jira issue in Sentry currently. So if a user has syncing setup to mark a Jira issue asDoneifResolvedin Sentry, then syncing will fail because they don't have aReasonfilled in.An improvement for this could be showing the failure reason via UI ?
Also I think we could mark this as halt, since our current Jira integration doesn't have the capability to fix this kind of issue. (Also supporting these workflow restrictions in Sentry would be :despairge: )
Corresponding sentry issue: https://sentry.sentry.io/issues/6083715764/events/b4a6349bd3b04467896ebab8cf873a1d/