Skip to content

chore(jira slos): Record APIError as a halt#89133

Closed
Christinarlong wants to merge 1 commit intomasterfrom
crl/record-halt-for-issue-not0existing
Closed

chore(jira slos): Record APIError as a halt#89133
Christinarlong wants to merge 1 commit intomasterfrom
crl/record-halt-for-issue-not0existing

Conversation

@Christinarlong
Copy link
Contributor

@Christinarlong Christinarlong commented Apr 8, 2025

While digging into status_sync_outbound on rotation, I saw our Jira SLOs for sync_status_outbound are kinda sus. For this one, we're recording failure in the case where

  1. User links a Sentry issue to a Jira ticket
  2. User deletes the Jira ticket, but we maintain the link on Sentry's side (this seems like a bug)
  3. User updates the Sentry issue, which leads us to reaching out to Jira to update a ghost ticket

Fixes: https://sentry.sentry.io/issues/5681104673/events/latest/?project=1&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D%20sync_status_outbound%20integration%3Ajira&referrer=latest-event&sort=date&statsPeriod=24h&stream_index=0

I have a followup for the ApiInvalidRequest errors (which I also think are halt), but I want to wait a bit to collect some more data before classifying that case officially.

@Christinarlong Christinarlong marked this pull request as ready for review April 8, 2025 23:52
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 8, 2025
@Christinarlong Christinarlong requested review from a team as code owners April 8, 2025 23:52
@codecov
Copy link

codecov bot commented Apr 9, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
25019 1 25018 299
View the top 1 failed test(s) by shortest run time
tests.sentry.sentry_metrics.test_snuba.SnubaMetricsInterfaceTest::test_count_query
Stack Traces | 3.46s run time
#x1B[1m#x1B[.../sentry/sentry_metrics/test_snuba.py#x1B[0m:53: in test_count_query
    data = get_series(
#x1B[1m#x1B[.../snuba/metrics/datasource.py#x1B[0m:835: in get_series
    ).get_snuba_queries()
#x1B[1m#x1B[.../snuba/metrics/query_builder.py#x1B[0m:1146: in get_snuba_queries
    component_entities = metric_field_obj.get_entity(
#x1B[1m#x1B[.../metrics/fields/base.py#x1B[0m:773: in get_entity
    return _get_entity_of_metric_mri(projects, self.metric_object.metric_mri, use_case_id)
#x1B[1m#x1B[.../metrics/fields/base.py#x1B[0m:274: in _get_entity_of_metric_mri
    raise InvalidParams(f"Raw metric {get_public_name_from_mri(metric_mri)} does not exist")
#x1B[1m#x1B[31mE   sentry.exceptions.InvalidParams: Raw metric measurements.speed does not exist#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Collaborator

@iamrajjoshi iamrajjoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm, could we add a test?

for ur 2nd point, i agree it a bug. we probably need to consume some webhook if we don't already

@getsantry getsantry bot added the Stale label Jun 6, 2025
@getsantry
Copy link
Contributor

getsantry bot commented Jun 6, 2025

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot removed the Stale label Jun 7, 2025
@getsantry
Copy link
Contributor

getsantry bot commented Jun 29, 2025

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Jun 29, 2025
@getsantry
Copy link
Contributor

getsantry bot commented Jul 22, 2025

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Jul 22, 2025
@Christinarlong Christinarlong deleted the crl/record-halt-for-issue-not0existing branch July 28, 2025 18:18
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants