Skip to content

chore(jira slos): Record APIError as a halt #89133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Christinarlong wants to merge 1 commit into from
Closed

chore(jira slos): Record APIError as a halt #89133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/sentry/integrations/jira/integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
from sentry.shared_integrations.exceptions import (
ApiError,
ApiHostError,
ApiInvalidRequestError,
ApiRateLimitedError,
ApiUnauthorized,
IntegrationError,
Expand Down Expand Up @@ -1053,7 +1054,12 @@ def sync_status_outbound(
logger.warning("jira.status-sync-fail", extra=log_context)
return

client.transition_issue(external_issue.key, transition["id"])
try:
client.transition_issue(external_issue.key, transition["id"])
except ApiInvalidRequestError:
raise
except ApiError as e:
self.raise_error(e)

def _get_done_statuses(self):
client = self.get_client()
Expand Down
14 changes: 11 additions & 3 deletions src/sentry/integrations/tasks/sync_status_outbound.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
)
from sentry.integrations.services.integration import integration_service
from sentry.models.group import Group, GroupStatus
from sentry.shared_integrations.exceptions import ApiInvalidRequestError, IntegrationError
from sentry.silo.base import SiloMode
from sentry.tasks.base import instrumented_task, retry, track_group_async_operation
from sentry.taskworker.config import TaskworkerConfig
Expand Down Expand Up @@ -68,9 +69,16 @@ def sync_status_outbound(group_id: int, external_issue_id: int) -> bool | None:
"status": group.status,
}
)
installation.sync_status_outbound(
external_issue, group.status == GroupStatus.RESOLVED, group.project_id
)
try:
installation.sync_status_outbound(
external_issue, group.status == GroupStatus.RESOLVED, group.project_id
)
except ApiInvalidRequestError:
raise
except IntegrationError as e:
lifecycle.record_halt(halt_reason=e)
return None

analytics.record(
"integration.issue.status.synced",
provider=integration.provider,
Expand Down
Loading