Skip to content

Conversation

@mujacica
Copy link
Contributor

@mujacica mujacica commented Aug 6, 2025

  • Currently building/releasing the Demo game takes ~2 hours
  • We needed a better way to execute the game quickly for the Demo/Sandbox
  • Split the build into two parts: build + package + upload and download + run
  • Use Github actions to manage files

@mujacica
Copy link
Contributor Author

mujacica commented Aug 7, 2025

@mujacica mujacica marked this pull request as ready for review August 7, 2025 06:40
@mujacica mujacica requested a review from tustanivsky August 7, 2025 06:40
Comment on lines +39 to +40
$exePath = Join-Path $downloadPath "SentryTower.exe"
if (!(Test-Path $exePath)) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential bug: The `run-demo` workflow uses an incorrect path to find the packaged executable, failing to account for the `WindowsNoEditor` subdirectory created during the build process.
  • Description: The Unreal Engine build process, using BuildCookRun with the -archive flag for the Win64 platform, packages the executable inside a WindowsNoEditor subdirectory. The run-demo.yml workflow downloads the build artifact but incorrectly attempts to find SentryTower.exe at the root of the downloaded directory. This path mismatch in the Join-Path command will cause the workflow to fail with a "file not found" error, preventing the demo from running.
  • Suggested fix: Update the path construction in run-demo.yml to include the WindowsNoEditor subdirectory created by the Unreal Engine build process. Change Join-Path $downloadPath "SentryTower.exe" to Join-Path $downloadPath "WindowsNoEditor" "SentryTower.exe".
    severity: 0.85, confidence: 0.98

Did we get this right? 👍 / 👎 to inform future reviews.

@mujacica mujacica merged commit bc9da79 into main Aug 7, 2025
2 checks passed
@mujacica mujacica deleted the run-demo-impl branch August 7, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants