-
-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Publish game artifacts during the build, run only the executable for demo runs #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mujacica
commented
Aug 6, 2025
- Currently building/releasing the Demo game takes ~2 hours
- We needed a better way to execute the game quickly for the Demo/Sandbox
- Split the build into two parts: build + package + upload and download + run
- Use Github actions to manage files
Contributor
Author
|
Build/Release: https://github.com/getsentry/unreal-tower/actions/runs/16779493517 Run was done in 3 minutes 14 seconds |
tustanivsky
approved these changes
Aug 7, 2025
Comment on lines
+39
to
+40
| $exePath = Join-Path $downloadPath "SentryTower.exe" | ||
| if (!(Test-Path $exePath)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential bug: The `run-demo` workflow uses an incorrect path to find the packaged executable, failing to account for the `WindowsNoEditor` subdirectory created during the build process.
- Description: The Unreal Engine build process, using
BuildCookRunwith the-archiveflag for theWin64platform, packages the executable inside aWindowsNoEditorsubdirectory. Therun-demo.ymlworkflow downloads the build artifact but incorrectly attempts to findSentryTower.exeat the root of the downloaded directory. This path mismatch in theJoin-Pathcommand will cause the workflow to fail with a "file not found" error, preventing the demo from running. - Suggested fix: Update the path construction in
run-demo.ymlto include theWindowsNoEditorsubdirectory created by the Unreal Engine build process. ChangeJoin-Path $downloadPath "SentryTower.exe"toJoin-Path $downloadPath "WindowsNoEditor" "SentryTower.exe".
severity: 0.85, confidence: 0.98
Did we get this right? 👍 / 👎 to inform future reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.