-
-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Publish game artifacts during the build, run only the executable for demo runs #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e96065e
Extract game before running, verify file exists
mujacica 98f8d17
Try finding correct file in artifacts
mujacica 885d698
Add destination path return
mujacica 67ee6a0
Use .exe directly in the download folder
mujacica 0e055e1
Test with return value
mujacica 9edd333
Extract output from the process
mujacica 45668fe
Add a little bit more debugging
mujacica d2edecb
Redirect outputs to text files
mujacica 9d42800
Run in docker instead natively
mujacica d9fe45b
Refactor the way we run docker
mujacica c7a3976
Package full Windows release directory
mujacica d5d2491
Use larger instance to build, run demo natively
mujacica e3583fe
Wait for app to finish
mujacica 86197d9
Use default runner for demo
mujacica File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential bug: The `run-demo` workflow uses an incorrect path to find the packaged executable, failing to account for the `WindowsNoEditor` subdirectory created during the build process.
BuildCookRunwith the-archiveflag for theWin64platform, packages the executable inside aWindowsNoEditorsubdirectory. Therun-demo.ymlworkflow downloads the build artifact but incorrectly attempts to findSentryTower.exeat the root of the downloaded directory. This path mismatch in theJoin-Pathcommand will cause the workflow to fail with a "file not found" error, preventing the demo from running.run-demo.ymlto include theWindowsNoEditorsubdirectory created by the Unreal Engine build process. ChangeJoin-Path $downloadPath "SentryTower.exe"toJoin-Path $downloadPath "WindowsNoEditor" "SentryTower.exe".severity: 0.85, confidence: 0.98
Did we get this right? 👍 / 👎 to inform future reviews.