[NO TICKET] Update PyYAML and fix CI #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidijac
commented
Jul 24, 2023
| @@ -4,11 +4,11 @@ on: [push] | |||
|
|
|||
| jobs: | |||
| test: | |||
| runs-on: ubuntu-18.04 | |||
| runs-on: ubuntu-20.04 | |||
There was a problem hiding this comment.
Was deprecated, didn't want to run
lidijac
commented
Jul 24, 2023
| strategy: | ||
| matrix: | ||
| python-version: [3.9, 3.8] | ||
| poetry-version: [1.1.7] | ||
| poetry-version: [1.3.1] |
There was a problem hiding this comment.
lock file was incompatible with old version, someone prob pushed a newer one, bumped this
lidijac
commented
Jul 24, 2023
| @@ -5,7 +5,7 @@ repos: | |||
| - id: black | |||
| additional_dependencies: ['click==8.0.4'] | |||
| - repo: https://github.com/PyCQA/isort | |||
| rev: 5.9.3 | |||
| rev: 5.12.0 | |||
There was a problem hiding this comment.
Was dying at the old version
lidijac
commented
Jul 24, 2023
| @@ -22,7 +22,7 @@ python = "^3.8" | |||
| marshmallow = "3.13.0" | |||
| marshmallow-dataclass = "8.5.3" | |||
| click = "8.0.1" | |||
| PyYAML = "5.4.1" | |||
| PyYAML = "6.0.1" | |||
There was a problem hiding this comment.
There was an issue with cython from last week affecting our version, options were to downgrade or upgrade. This is visible on my local machine where auto-pr tool broke.
pip seemed to fail to build package:
PyYAML==5.4.1
Some possibly relevant errors from pip install:
error: subprocess-exited-with-error
AttributeError: cython_sources
ctbur
approved these changes
Jul 24, 2023
|
Thanks for the fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
CI was broken. History of fails here. I still need to see if it will publish the new version.
How to test the change
Checklist
CHANGELOG.mdhas been updated to reflect changes