Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO TICKET] Update PyYAML and fix CI #155

Merged
merged 5 commits into from
Jul 24, 2023
Merged

[NO TICKET] Update PyYAML and fix CI #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e0ffb86
Update runs on to supported ubuntu version
lidijac Jul 24, 2023
f23ff3e
Update poetry version
lidijac Jul 24, 2023
fc2c396
Bump PyYAML
lidijac Jul 24, 2023
652dbe9
Try newer Poetry version
lidijac Jul 24, 2023
dd35f7a
Bump isort
lidijac Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ on: [push]

jobs:
test:
runs-on: ubuntu-18.04
runs-on: ubuntu-20.04
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was deprecated, didn't want to run

strategy:
matrix:
python-version: [3.9, 3.8]
poetry-version: [1.1.7]
poetry-version: [1.3.1]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lock file was incompatible with old version, someone prob pushed a newer one, bumped this

env:
IS_COVERAGE_ALLOWED: ${{ secrets.CODACY_PROJECT_TOKEN != '' }}
IS_MASTER_BRANCH: ${{ github.ref == 'refs/heads/master' }}
Expand All @@ -27,7 +27,7 @@ jobs:
- name: Run tests
run: poetry run pytest --cov-report xml --cov=autopr test/ -v
lint:
runs-on: ubuntu-18.04
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v2
- name: Set up Python
Expand All @@ -37,7 +37,7 @@ jobs:
- name: Install poetry
uses: abatilo/[email protected]
with:
poetry-version: 1.1.7
poetry-version: 1.3.1
- name: Install pip dependencies
run: poetry install
- name: Run pre-commit
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:

jobs:
publish:
runs-on: ubuntu-18.04
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@master
- uses: actions/setup-python@v1
Expand All @@ -15,7 +15,7 @@ jobs:
- name: Install poetry
uses: abatilo/[email protected]
with:
poetry-version: 1.1.7
poetry-version: 1.3.1
- name: Install pip dependencies
run: poetry install
- name: Package
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ repos:
- id: black
additional_dependencies: ['click==8.0.4']
- repo: https://github.com/PyCQA/isort
rev: 5.9.3
rev: 5.12.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was dying at the old version

hooks:
- id: isort
- repo: https://github.com/pre-commit/mirrors-mypy
Expand Down
77 changes: 44 additions & 33 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ python = "^3.8"
marshmallow = "3.13.0"
marshmallow-dataclass = "8.5.3"
click = "8.0.1"
PyYAML = "5.4.1"
PyYAML = "6.0.1"
Copy link
Member Author

@lidijac lidijac Jul 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was an issue with cython from last week affecting our version, options were to downgrade or upgrade. This is visible on my local machine where auto-pr tool broke.

pip seemed to fail to build package:
    PyYAML==5.4.1

Some possibly relevant errors from pip install:
    error: subprocess-exited-with-error
    AttributeError: cython_sources

PyGithub = "1.55"
single-source = "0.2.0"

Expand Down
Loading