[naga] Validate that all order-sensitive expressions are emitted. #5769
+149
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that every expression whose value is affected by statements' side effects is covered by an `Emit` statement. See the comments on `Expression::is_order_sensitive` for details. Fixes gfx-rs#5763.
Add a test to ensure that module validation will fail if a function uses an `Expression` that is not covered by any `Emit` statement.
|
Leaving this as a draft, because, naturally, our existing front ends don't actually meet the new requirement: --- STDERR: naga::naga-test snapshots::convert_glsl_folder ---
thread 'snapshots::convert_glsl_folder' panicked at naga/tests/snapshots.rs:1054:10:
called `Result::unwrap()` on an `Err` value: WithSpan { inner: Function { handle: [1], name: "main", source: EmitMissing([7]) }, spans: [(Span { start: 65, end: 76 }, "naga::Function [1]"), (Span { start: 84, end: 87 }, "naga::Expression [7]")] }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that every expression whose value is affected by statements' side effects is covered by an
Emitstatement.See the comments on
Expression::is_order_sensitivefor details.Fixes #5763.