Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[naga] Validate that all order-sensitive expressions are emitted. #5769

Draft
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Commits on May 31, 2024

  1. Configuration menu
    Copy the full SHA
    ef0d93a View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2024

  1. [naga] Validate that all order-sensitive expressions are emitted.

    Ensure that every expression whose value is affected by statements'
    side effects is covered by an `Emit` statement.
    
    See the comments on `Expression::is_order_sensitive` for details.
    
    Fixes gfx-rs#5763.
    jimblandy committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    fd3a81d View commit details
    Browse the repository at this point in the history
  2. [naga] Test that all used expressions are covered by some Emit.

    Add a test to ensure that module validation will fail if a function
    uses an `Expression` that is not covered by any `Emit` statement.
    jimblandy committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    396d6a3 View commit details
    Browse the repository at this point in the history