Expose conversions between TextureFormat and naga::StorageFormat #6185
+48
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful when generating compute shaders at runtime that need to support arbitrary storage texture formats. Due to the orphan rule, I placed these functions in an extension trait in wgpu::util.
cwfitzgerald
approved these changes
Oct 21, 2024
| /// use wgpu::util::TextureFormatExt; | ||
| /// assert_eq!(wgpu::TextureFormat::Bgra8Unorm.to_storage_format(), Some(wgpu::naga::StorageFormat::Bgra8Unorm)); | ||
| /// ``` | ||
| #[cfg_attr(docsrs, doc(cfg(any(wgpu_core, naga))))] |
There was a problem hiding this comment.
We shouldn't need this, we have https://github.com/gfx-rs/wgpu/blob/trunk/wgpu/src/lib.rs#L17 which should take care of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
none
Description
Exposes conversions between TextureFormat and naga::StorageFormat.
This is useful when generating compute shaders at runtime that need to support arbitrary storage texture formats.
Due to the orphan rule, I placed these functions in an extension trait in wgpu::util.
Testing
Doctests included.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.