[dx12] Don't panic if MaxSupportedFeatureLevel wasn't set by query
#8806
Conversation
ErichDonGubler
left a comment
ErichDonGubler
left a comment
There was a problem hiding this comment.
Super minor changes requested. Otherwise, thanks for taking this on! 🙂
| Direct3D::D3D_FEATURE_LEVEL_12_0 => FeatureLevel::_12_0, | ||
| Direct3D::D3D_FEATURE_LEVEL_12_1 => FeatureLevel::_12_1, | ||
| Direct3D::D3D_FEATURE_LEVEL_12_2 => FeatureLevel::_12_2, | ||
| Direct3D::D3D_FEATURE_LEVEL(0) => return None, |
There was a problem hiding this comment.
issue(non-blocking): I suspect we'll also want to report this via telemetry. That sound interesting, @teoxoy?
There was a problem hiding this comment.
I doubt this will be worth reporting given my comment below. Also completely out of my domain of expertise lol. Seems to be an issue with some windows versions that is easily bypassed.
I'll leave this unresolved for visibility
ErichDonGubler
changed the title
MaxSupportedFeatureLevel wasn't set by query
|
In the OP:
This is an issue for everyone trying to use wgpu on native, Mozilla is just the first to discover it. 😉 |
We don't have 100% certainty that the case we're trying to handle is the actual behavior causing crashes here (viz., we're not sure that |
|
@ErichDonGubler I asked in the directx discord. I'm told that what we're seeing "shouldnt be possible" but also isn't a driver bug; the person is responding with single sentences and I can't figure out what they mean. Once I get feedback I'll also document that here in a comment. |
|
Inlining my notes from bug 2007754, comment 7:
ETA: For reference, that's this commit stack: https://github.com/gfx-rs/wgpu/compare/aba9161b72c028aa8a1ce15aabd92e3c3cdb2da3..6fe22a0b59f256648eedd7652247c23490162d1a |
@ErichDonGubler So, were you able to get a crash locally with the test case in #8803? Does this PR fix that crash? |
|
Also, I will update this with information from the DX12 discord server: This is a bug in Microsoft's DirectX code on older Windows versions. The fix is just as I did it here, and some sample code shared by several users had basically identical code to what we would have after this lands. I'd still like confirmation that this actually fixes the bug but I'd be very surprised if it didn't. |
3 participants
Connections
Closes #8803
Description
Fixes issue with device not supporting our required D3D12 feature level, and us entering unreachable code. This is an issue for mozilla.
Testing
Hasn't been, @ErichDonGubler can you verify that this should fix it?
Squash or Rebase?
Squash due to only commit being named stupid
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.