Skip to content

[dx12] Don't panic if MaxSupportedFeatureLevel wasn't set by query #8806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
inner-daemons wants to merge 8 commits into
base: trunk
Choose a base branch
from
+8 −1
Open

[dx12] Don't panic if MaxSupportedFeatureLevel wasn't set by query #8806

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c001579
Will this fix?
inner-daemons Jan 3, 2026
ab2dceb
Lmao I need to go to bed
inner-daemons Jan 3, 2026
cfbffe2
Maybe this'll work
inner-daemons Jan 3, 2026
f3a3a46
Added changelog entry
inner-daemons Jan 3, 2026
6f6371b
Update CHANGELOG.md
inner-daemons Jan 6, 2026
c655baf
Added a comment and addressed Erich's suggestion
inner-daemons Jan 6, 2026
9e82d0f
Merge remote-tracking branch 'upstream/trunk' into fix-8803
inner-daemons Jan 6, 2026
aafe2f6
Merge branch 'trunk' into fix-8803
inner-daemons Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,10 @@ Bottom level categories:
- `DisplayHandle` should now be passed to `InstanceDescriptor` for correct EGL initialization on Wayland. By @MarijnS95 in [#8012](https://github.com/gfx-rs/wgpu/pull/8012)
Note that the existing workaround to create surfaces before the adapter is no longer valid.

#### DX12

- Unreachable code entered during adapter enumeration on older DX12 environments that didn't support a high enough D3D12FeatureLevel was fixed. By @inner-daemons in [#8806](https://github.com/gfx-rs/wgpu/pull/8806).

### Documentation

#### General
Expand Down
1 change: 1 addition & 0 deletions wgpu-hal/src/dx12/adapter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ impl super::Adapter {
Direct3D::D3D_FEATURE_LEVEL_12_0 => FeatureLevel::_12_0,
Direct3D::D3D_FEATURE_LEVEL_12_1 => FeatureLevel::_12_1,
Direct3D::D3D_FEATURE_LEVEL_12_2 => FeatureLevel::_12_2,
Direct3D::D3D_FEATURE_LEVEL(0) => return None,
Copy link
Member

@ErichDonGubler ErichDonGubler Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue(non-blocking): I suspect we'll also want to report this via telemetry. That sound interesting, @teoxoy?

Copy link
Collaborator Author

@inner-daemons inner-daemons Jan 6, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt this will be worth reporting given my comment below. Also completely out of my domain of expertise lol. Seems to be an issue with some windows versions that is easily bypassed.

I'll leave this unresolved for visibility

Copy link
Member

@teoxoy teoxoy Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to have telemetry for this since it should count towards the "total nr of people without D3D12" counter. I can also open another PR for it.

_ => unreachable!(),
};

Expand Down