Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snippets #33

Merged
merged 8 commits into from
Nov 15, 2019
Merged

Snippets #33

merged 8 commits into from
Nov 15, 2019

Conversation

GlenNicholls
Copy link
Contributor

PR for snippets based on #32. The syntaxes will be more work as I'm not sure at this time if I have something messed up in my VSC. Per @tgingold, he has syntax highlighting for all identifiers, but I'm not sure yet why it doesn't work for me. Should that be broken off to a separate issue?

I added 2008 to the name, prefix, and description. However, this might not need to be in the prefix (*_2008) as VSC will show the snippet name next to the suggestion if there are multiple snippets with the same prefix. I did not add 2008 snippets to separate JSON file as I don't see the value since there aren't that many per file now that they're grouped.

Lastly, there are comments in some of the JSON as I don't know a better place to document this until this is all merged to master. It isn't super critical for that support as I rarely use it, but I'm sure someone will at some point.

As for this PR, please provide:

  • suggestions for additional snippets that would be useful
  • adjustments for current snippets
  • feedback about file names and possible re-ordering based on grouping in syntaxes

@GlenNicholls
Copy link
Contributor Author

GlenNicholls commented Nov 15, 2019

@tgingold I found this and I'm contemplating changing to this structure. Do you think seperating the snippets out to a single per file is reasonable? I think that emacs sublime emulator is a good goal to set for syntaxes, snippets, and macros.

Note about the /t, if the autodetection of a file for tabs/spaces is enabled, these are automagically converted to the user-configured number of spaces.

Lastly, in that link above, the author abbreviates the prefix. I used _ along with full words to be verbose, but I kind of prefer the abbreviations. Thoughts?

@tgingold tgingold merged commit 2c049a4 into ghdl:master Nov 15, 2019
@tgingold
Copy link
Member

Thanks!

To be honest, I have no precise idea of how to organize snippets. So do as you prefer.
One per file might be a good idea!

@GlenNicholls GlenNicholls deleted the snippets_syntax branch November 15, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants