Merge pull request #559 from WJXHenry/issue-508

Repository 'listCommits' working when options omitted
github-tools · May 27, 2019 · 64c34b9 · 64c34b9
2 parents 935783f + f2cfa93
commit 64c34b9
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/lib/Repository.js b/lib/Repository.js
@@ -188,7 +188,10 @@ class Repository extends Requestable {
     */
    listCommits(options, cb) {
       options = options || {};
-
+      if (typeof options === 'function') {
+         cb = options;
+         options = {};
+      }
       options.since = this._dateToISO(options.since);
       options.until = this._dateToISO(options.until);
 

diff --git a/test/repository.spec.js b/test/repository.spec.js
@@ -125,6 +125,18 @@ describe('Repository', function() {
       });
 
       it('should list commits with no options', function(done) {
+         remoteRepo.listCommits(assertSuccessful(done, function(err, commits) {
+            expect(commits).to.be.an.array();
+            expect(commits.length).to.be.above(0);
+
+            expect(commits[0]).to.have.own('commit');
+            expect(commits[0]).to.have.own('author');
+
+            done();
+         }));
+      });
+
+      it('should list commits with null options', function(done) {
          remoteRepo.listCommits(null, assertSuccessful(done, function(err, commits) {
             expect(commits).to.be.an.array();
             expect(commits.length).to.be.above(0);