Merge pull request #1753 from EliahKagan/fds

Let close_fds be True on all platforms
gitpython-developers · Dec 1, 2023 · 3dbf5b3 · 3dbf5b3
2 parents 7c423b4 + 78d63d9
commit 3dbf5b3
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 2 deletions.
diff --git a/git/cmd.py b/git/cmd.py
@@ -1001,7 +1001,6 @@ def execute(
                     stderr=PIPE,
                     stdout=stdout_sink,
                     shell=shell,
-                    close_fds=(os.name == "posix"),  # Unsupported on Windows.
                     universal_newlines=universal_newlines,
                     creationflags=PROC_CREATIONFLAGS,
                     **subprocess_kwargs,

diff --git a/git/index/fun.py b/git/index/fun.py
@@ -102,7 +102,6 @@ def run_commit_hook(name: str, index: "IndexFile", *args: str) -> None:
             stdout=subprocess.PIPE,
             stderr=subprocess.PIPE,
             cwd=index.repo.working_dir,
-            close_fds=(os.name == "posix"),
             creationflags=PROC_CREATIONFLAGS,
         )
     except Exception as ex: