-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated plot to make use of data minimum for setting up plot Y axis #241
Open
sivamgr
wants to merge
1
commit into
gizak:master
Choose a base branch
from
sivamgr:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,7 @@ type Plot struct { | |
|
||
Data [][]float64 | ||
DataLabels []string | ||
MinVal float64 | ||
MaxVal float64 | ||
|
||
LineColors []Color | ||
|
@@ -76,7 +77,7 @@ func NewPlot() *Plot { | |
} | ||
} | ||
|
||
func (self *Plot) renderBraille(buf *Buffer, drawArea image.Rectangle, maxVal float64) { | ||
func (self *Plot) renderBraille(buf *Buffer, drawArea image.Rectangle, minVal float64, maxVal float64) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You missed implementation of this part |
||
canvas := NewCanvas() | ||
canvas.Rectangle = drawArea | ||
|
||
|
@@ -118,12 +119,13 @@ func (self *Plot) renderBraille(buf *Buffer, drawArea image.Rectangle, maxVal fl | |
canvas.Draw(buf) | ||
} | ||
|
||
func (self *Plot) renderDot(buf *Buffer, drawArea image.Rectangle, maxVal float64) { | ||
func (self *Plot) renderDot(buf *Buffer, drawArea image.Rectangle, minVal float64, maxVal float64) { | ||
r := maxVal - minVal | ||
switch self.PlotType { | ||
case ScatterPlot: | ||
for i, line := range self.Data { | ||
for j, val := range line { | ||
height := int((val / maxVal) * float64(drawArea.Dy()-1)) | ||
height := int(((val - minVal) / r) * float64(drawArea.Dy()-1)) | ||
point := image.Pt(drawArea.Min.X+(j*self.HorizontalScale), drawArea.Max.Y-1-height) | ||
if point.In(drawArea) { | ||
buf.SetCell( | ||
|
@@ -137,7 +139,7 @@ func (self *Plot) renderDot(buf *Buffer, drawArea image.Rectangle, maxVal float6 | |
for i, line := range self.Data { | ||
for j := 0; j < len(line) && j*self.HorizontalScale < drawArea.Dx(); j++ { | ||
val := line[j] | ||
height := int((val / maxVal) * float64(drawArea.Dy()-1)) | ||
height := int(((val - minVal) / r) * float64(drawArea.Dy()-1)) | ||
buf.SetCell( | ||
NewCell(self.DotMarkerRune, NewStyle(SelectColor(self.LineColors, i))), | ||
image.Pt(drawArea.Min.X+(j*self.HorizontalScale), drawArea.Max.Y-1-height), | ||
|
@@ -147,7 +149,8 @@ func (self *Plot) renderDot(buf *Buffer, drawArea image.Rectangle, maxVal float6 | |
} | ||
} | ||
|
||
func (self *Plot) plotAxes(buf *Buffer, maxVal float64) { | ||
func (self *Plot) plotAxes(buf *Buffer, minVal float64, maxVal float64) { | ||
r := maxVal - minVal | ||
// draw origin cell | ||
buf.SetCell( | ||
NewCell(BOTTOM_LEFT, NewStyle(ColorWhite)), | ||
|
@@ -188,10 +191,11 @@ func (self *Plot) plotAxes(buf *Buffer, maxVal float64) { | |
x += (len(label) + xAxisLabelsGap) * self.HorizontalScale | ||
} | ||
// draw y axis labels | ||
verticalScale := maxVal / float64(self.Inner.Dy()-xAxisLabelsHeight-1) | ||
verticalScale := r / float64(self.Inner.Dy()-xAxisLabelsHeight-1) | ||
for i := 0; i*(yAxisLabelsGap+1) < self.Inner.Dy()-1; i++ { | ||
lblY := minVal + float64(i)*verticalScale*(yAxisLabelsGap+1) | ||
buf.SetString( | ||
fmt.Sprintf("%.2f", float64(i)*verticalScale*(yAxisLabelsGap+1)), | ||
fmt.Sprintf("%.2f", lblY), | ||
NewStyle(ColorWhite), | ||
image.Pt(self.Inner.Min.X, self.Inner.Max.Y-(i*(yAxisLabelsGap+1))-2), | ||
) | ||
|
@@ -202,12 +206,14 @@ func (self *Plot) Draw(buf *Buffer) { | |
self.Block.Draw(buf) | ||
|
||
maxVal := self.MaxVal | ||
minVal := self.MinVal | ||
if maxVal == 0 { | ||
maxVal, _ = GetMaxFloat64From2dSlice(self.Data) | ||
minVal, _ = GetMinFloat64From2dSlice(self.Data) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So if |
||
} | ||
|
||
if self.ShowAxes { | ||
self.plotAxes(buf, maxVal) | ||
self.plotAxes(buf, minVal, maxVal) | ||
} | ||
|
||
drawArea := self.Inner | ||
|
@@ -220,8 +226,8 @@ func (self *Plot) Draw(buf *Buffer) { | |
|
||
switch self.Marker { | ||
case MarkerBraille: | ||
self.renderBraille(buf, drawArea, maxVal) | ||
self.renderBraille(buf, drawArea, minVal, maxVal) | ||
case MarkerDot: | ||
self.renderDot(buf, drawArea, maxVal) | ||
self.renderDot(buf, drawArea, minVal, maxVal) | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cannot get max value from empty slice
->cannot get min value from empty slice