Fix(RuleRight): remove useless fields for RuleRight Form

[stonebuzz]

Checklist before requesting a review

Please delete options that are not relevant.

• I have read the CONTRIBUTING document.
• I have performed a self-review of my code.
• I have added tests that prove my fix is effective or that my feature works.
• This change requires a documentation update.

Description

Since the UI refactor of rules:

#17203

The form for authorization rules contains two additional fields that do not work and do not appear to be used. Their presence in this location seems rather odd.

An initial inconsistency had been detected and fixed here:

https://github.com/glpi-project/glpi/pull/19656/files#diff-186234e2e73b65f55a4e8779745ad83d0863119d64b860b3f80260509049f3d0

However, these two fields are now displayed systematically.

Screenshots (if appropriate):

[trasher]

I do not know if those fields are used or not, but they were present before Twig migration

[cedric-anne]

I do not know if those fields are used or not, but they were present before Twig migration

It seems that they were used only in a specific case:

The condition on short removed in #19656 must probably be restored and its lack of definition handled properly.

[cconard96]

Should only be the "short" form in the context of the Rules tab in the Entity form I think.

[cedric-anne]

See @cconard96 comment.

[cedric-anne]

As far as I understand, to restore the behaviour of GLPI 10.0, you have to invert conditions. Also, the variable name is ambiguous, so it should be renamed.

[trasher]

@cedric-anne variable name is still short, did you miss a pull before you force push?

[cedric-anne]

In fact, the required changes could be more complex.

Before #17203, the rules forms displayed in the entity tab were processed by the Entity::executeAddRule() method. This is no longer the case. Maybe it should be restored, but I do not really know how it is supposed to work.

[cedric-anne]

@cedric-anne variable name is still short, did you miss a pull before you force push?

I reverted, it is used elsewhere.

[cconard96]

The form in the context of Entities is still broken functionally. I don't really understand the usability of the extra fields, but any RuleRight created from here is done with no criteria or actions.